[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118691#comment-14118691
]
Thejas M Nair commented on HIVE-6928:
-
The patch does not have a test that verifies
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064611#comment-14064611
]
Hive QA commented on HIVE-6928:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065349#comment-14065349
]
Xuefu Zhang commented on HIVE-6928:
---
The test failures don't seem related to the patch. I
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065719#comment-14065719
]
Lefty Leverenz commented on HIVE-6928:
--
The --truncateTable option needs to be
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065726#comment-14065726
]
Xuefu Zhang commented on HIVE-6928:
---
Thanks, Lefty.
Beeline should not chop off
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064283#comment-14064283
]
Xuefu Zhang commented on HIVE-6928:
---
I have started wondering why test wasn't triggered.
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062430#comment-14062430
]
Xuefu Zhang commented on HIVE-6928:
---
The latest patch looks good to me. Can we have a RB
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063008#comment-14063008
]
ferdinand commented on HIVE-6928:
-
review board entry was created:
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031508#comment-14031508
]
Szehon Ho commented on HIVE-6928:
-
The concern does make sense. I only have mysql now, and
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030560#comment-14030560
]
Hive QA commented on HIVE-6928:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030630#comment-14030630
]
Xuefu Zhang commented on HIVE-6928:
---
[~chinnalalam] could you please update RB with your
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031432#comment-14031432
]
Thejas M Nair commented on HIVE-6928:
-
I have a few concerns about this patch.
This
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029183#comment-14029183
]
Chinna Rao Lalam commented on HIVE-6928:
Created review board entry.
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029189#comment-14029189
]
Xuefu Zhang commented on HIVE-6928:
---
+1, patch looks good. Minor comment on RB.
Beeline
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029550#comment-14029550
]
Chinna Rao Lalam commented on HIVE-6928:
Reworked the patch. Thanks for the review
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028250#comment-14028250
]
Xuefu Zhang commented on HIVE-6928:
---
Could we have a review board entry which makes the
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027222#comment-14027222
]
Szehon Ho commented on HIVE-6928:
-
[~brocknoland] , [~xuefuz], any of you guys have a cycle
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010240#comment-14010240
]
Szehon Ho commented on HIVE-6928:
-
Thanks Chinna, +1 (non-binding).
Beeline should not
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008929#comment-14008929
]
Hive QA commented on HIVE-6928:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008317#comment-14008317
]
Chinna Rao Lalam commented on HIVE-6928:
Hi Szehon Ho, Thanks for reviewing the
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005125#comment-14005125
]
Szehon Ho commented on HIVE-6928:
-
Thanks [~chinnalalam] for the fix.
One minor nit
[
https://issues.apache.org/jira/browse/HIVE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986266#comment-13986266
]
Hive QA commented on HIVE-6928:
---
{color:red}Overall{color}: -1 at least one tests failed
22 matches
Mail list logo