[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-23 Thread Vikram Dixit K (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289830#comment-14289830
 ] 

Vikram Dixit K commented on HIVE-9404:
--

[~ekoifman] Does this need to ported to branch 1.0?

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Fix For: 0.15.0

 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-23 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289844#comment-14289844
 ] 

Eugene Koifman commented on HIVE-9404:
--

[~vikram.dixit] yes but only if you are also including HIVE-9390 

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Fix For: 0.15.0

 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-23 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290327#comment-14290327
 ] 

Eugene Koifman commented on HIVE-9404:
--

Committed to 0.14 and 1.0

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Fix For: 0.15.0, 0.14.1, 1.0.0

 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-19 Thread Alan Gates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283205#comment-14283205
 ] 

Alan Gates commented on HIVE-9404:
--

Ok, that's fine.  +1 for the patch then.

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-19 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283153#comment-14283153
 ] 

Eugene Koifman commented on HIVE-9404:
--

I actually saw this state on Azure which uses MsSQL.  More importantly, we 
often get this when checking out a connection from the pool, i.e. isRetryable() 
has to handle not having a Connection I can add the check but I think it 
will be of limited use at least for this type of error

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-19 Thread Alan Gates (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283057#comment-14283057
 ] 

Alan Gates commented on HIVE-9404:
--

+1, the changes look fine.  

As a side note, I'm wondering if in isRetryable the line 
{{if(08S01.equalsIgnoreCase(sqlException.getSQLState()))}} shouldn't include 
a check whether dbProduct is MySQL (I know I should have said this in the 
review of HIVE-9390 instead).

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-19 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282891#comment-14282891
 ] 

Eugene Koifman commented on HIVE-9404:
--

these test failures are not related - they've been happening in other runs

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-18 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281721#comment-14281721
 ] 

Hive QA commented on HIVE-9404:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12692930/HIVE-9404.patch

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 7225 tests 
executed
*Failed tests:*
{noformat}
TestMiniTezCliDriver-enforce_order.q-cbo_windowing.q-tez_schema_evolution.q-and-12-more
 - did not produce a TEST-*.xml file
TestMiniTezCliDriver-update_orig_table.q-vectorization_13.q-update_after_multiple_inserts.q-and-12-more
 - did not produce a TEST-*.xml file
TestMiniTezCliDriver-vector_coalesce.q-dynamic_partition_pruning.q-tez_union_group_by.q-and-12-more
 - did not produce a TEST-*.xml file
TestMiniTezCliDriver-vector_data_types.q-orc_merge5.q-vectorization_limit.q-and-12-more
 - did not produce a TEST-*.xml file
TestMiniTezCliDriver-vector_partitioned_date_time.q-vector_non_string_partition.q-tez_dml.q-and-12-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-external_table_with_space_in_location_path.q-infer_bucket_sort_merge.q-auto_sortmerge_join_16.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-leftsemijoin_mr.q-bucket5.q-root_dir_external_table.q-and-1-more
 - did not produce a TEST-*.xml file
TestNegativeMinimrCliDriver-udf_local_resource.q-mapreduce_stack_trace_turnoff_hadoop20.q-mapreduce_stack_trace.q-and-5-more
 - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_bucketmapjoin10
org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2412/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2412/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2412/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12692930 - PreCommit-HIVE-TRUNK-Build

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9404) NPE in org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()

2015-01-17 Thread Eugene Koifman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281518#comment-14281518
 ] 

Eugene Koifman commented on HIVE-9404:
--

[~alangates] could you review please?  This is a small followup to HIVE-9390

 NPE in 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct()
 -

 Key: HIVE-9404
 URL: https://issues.apache.org/jira/browse/HIVE-9404
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 0.15.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
 Attachments: HIVE-9404.patch


 {noformat}
 Caused by: java.lang.NullPointerException
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.determineDatabaseProduct(TxnHandler.java:1015)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.checkRetryable(TxnHandler.java:906)
   at 
 org.apache.hadoop.hive.metastore.txn.TxnHandler.getOpenTxns(TxnHandler.java:238)
   at 
 org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_open_txns(HiveMetaStore.java:5321)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)