Gopal V created HIVE-20416:
------------------------------

             Summary: LLAP: Fail to package LLAP if the Xmx computed is 0
                 Key: HIVE-20416
                 URL: https://issues.apache.org/jira/browse/HIVE-20416
             Project: Hive
          Issue Type: Bug
          Components: llap
            Reporter: Gopal V


{code}
      if (options.getXmx() != -1) {
        // Needs more explanation here
        // Xmx is not the max heap value in JDK8. You need to subtract 50% of 
the survivor fraction
        // from this, to get actual usable memory before it goes into GC
        xmx = options.getXmx();
        long xmxMb = (xmx / (1024L * 1024L));
        conf.setLong(ConfVars.LLAP_DAEMON_MEMORY_PER_INSTANCE_MB.varname, 
xmxMb);
        
propsDirectOptions.setProperty(ConfVars.LLAP_DAEMON_MEMORY_PER_INSTANCE_MB.varname,
            String.valueOf(xmxMb));
{code}

needs a check for the value being so low that start-up (or all queries) will 
fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to