Re: Review Request: for HIVE-2068

2011-04-15 Thread Siying Dong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/540/
---

(Updated 2011-04-15 18:37:21.441402)


Review request for hive and namit jain.


Changes
---

fix a small logic bug.


Summary
---

For HIVE-2068


This addresses bug HIVE-2068.
https://issues.apache.org/jira/browse/HIVE-2068


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1091258 
  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1091258 
  trunk/conf/hive-default.xml 1091258 
  trunk/hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/CommandNeedRetryException.java 
PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/LimitOperator.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java 
1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java 1091258 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessor.java 
1091258 
  trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 1091258 
  trunk/ql/src/test/queries/clientpositive/global_limit.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/global_limit.q.out PRE-CREATION 
  trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java 1091258 

Diff: https://reviews.apache.org/r/540/diff


Testing
---

added a test to test suite.


Thanks,

Siying

Review Request: for HIVE-2068

2011-04-07 Thread Siying Dong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/540/
---

Review request for hive and namit jain.


Summary
---

For HIVE-2068


This addresses bug HIVE-2068.
https://issues.apache.org/jira/browse/HIVE-2068


Diffs
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1086466 
  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1086466 
  trunk/conf/hive-default.xml 1086466 
  trunk/hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/CommandNeedRetryException.java 
PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/LimitOperator.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java 
1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java 1086466 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessor.java 
1086466 
  trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 1086466 
  trunk/ql/src/test/queries/clientpositive/global_limit.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/global_limit.q.out PRE-CREATION 
  trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java 1086466 

Diff: https://reviews.apache.org/r/540/diff


Testing
---

added a test to test suite.


Thanks,

Siying