Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-07-06 Thread Thiruvel Thirumoolan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/ --- (Updated 2011-07-06 12:14:34.148278) Review request for hive, Ning Zhang and

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-07-06 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/#review966 --- Ship it! +1 Looks good to me. - Ashutosh On 2011-07-06 12:14:34,

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-29 Thread Thiruvel Thirumoolan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/ --- (Updated 2011-06-29 11:17:50.481535) Review request for hive, Ning Zhang and

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/#review930 --- Changes look fine to me. Ning, what do you think about removing the

Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-28 Thread Thiruvel Thirumoolan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/973/ --- Review request for hive, Ashutosh Chauhan, Ning Zhang, and Amareshwari

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/#review905 ---

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-24 Thread Thiruvel Thirumoolan
On 2011-06-23 16:49:59, Ashutosh Chauhan wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 591 https://reviews.apache.org/r/949/diff/1/?file=21560#file21560line591 This may not be always successful. You may fail to create dirs for number

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-24 Thread Thiruvel Thirumoolan
On 2011-06-24 06:32:41, Amareshwari Sriramadasu wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 159 https://reviews.apache.org/r/949/diff/1/?file=21562#file21562line159 I don't think we can just remove these public apis. Shall we deprecate

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-24 Thread Ashutosh Chauhan
On 2011-06-23 16:49:59, Ashutosh Chauhan wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 591 https://reviews.apache.org/r/949/diff/1/?file=21560#file21560line591 This may not be always successful. You may fail to create dirs for number

Re: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement

2011-06-23 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/949/#review898 ---