Re: Review Request: HIVE-3213: ODBC API enhancements

2012-10-07 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5685/ --- (Updated Oct. 8, 2012, 5:10 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3213: ODBC API enhancements

2012-10-07 Thread Prasad Mujumdar
On Aug. 10, 2012, 8:31 p.m., Carl Steinbach wrote: odbc/src/cpp/hiveclient.def, line 1 https://reviews.apache.org/r/5685/diff/1/?file=117650#file117650line1 Missing ASF license header. Done On Aug. 10, 2012, 8:31 p.m., Carl Steinbach wrote: odbc/src/cpp/HiveResultSet.cpp, line

Re: Review Request: HIVE-3213: ODBC API enhancements

2012-08-10 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5685/#review10147 --- Looks good overall. Most of things I commented on have to do with

Review Request: HIVE-3213: ODBC API enhancements

2012-06-29 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5685/ --- Review request for hive and Carl Steinbach. Description --- Enhanced ODBC