Re: Review Request: Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path.

2012-08-05 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6313/#review9874
---

Ship it!


Ship It!

- Ashutosh Chauhan


On Aug. 2, 2012, 4:51 a.m., Kanna Karanam wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/6313/
 ---
 
 (Updated Aug. 2, 2012, 4:51 a.m.)
 
 
 Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh 
 Chauhan.
 
 
 Description
 ---
 
 Several .q files have Unix absolute paths for Cat utility so all of them are 
 failing on Windows even with CygWin support. 
 
 
 This addresses bug HIVE-3327.
 https://issues.apache.org/jira/browse/HIVE-3327
 
 
 Diffs
 -
 
   trunk/contrib/src/test/queries/clientpositive/serde_typedbytes.q 1368192 
   trunk/contrib/src/test/queries/clientpositive/serde_typedbytes2.q 1368192 
   trunk/contrib/src/test/queries/clientpositive/serde_typedbytes3.q 1368192 
   trunk/contrib/src/test/queries/clientpositive/serde_typedbytes4.q 1368192 
   trunk/contrib/src/test/results/clientpositive/serde_typedbytes.q.out 
 1368192 
   trunk/contrib/src/test/results/clientpositive/serde_typedbytes2.q.out 
 1368192 
   trunk/contrib/src/test/results/clientpositive/serde_typedbytes3.q.out 
 1368192 
   trunk/contrib/src/test/results/clientpositive/serde_typedbytes4.q.out 
 1368192 
   trunk/ql/src/test/queries/clientnegative/clusterbydistributeby.q 1368192 
   trunk/ql/src/test/queries/clientnegative/clusterbyorderby.q 1368192 
   trunk/ql/src/test/queries/clientnegative/clusterbysortby.q 1368192 
   trunk/ql/src/test/queries/clientnegative/orderbysortby.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input14.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input14_limit.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input17.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input18.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input34.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input35.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input36.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input38.q 1368192 
   trunk/ql/src/test/queries/clientpositive/input5.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce1.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce2.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce3.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce4.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce7.q 1368192 
   trunk/ql/src/test/queries/clientpositive/mapreduce8.q 1368192 
   trunk/ql/src/test/queries/clientpositive/newline.q 1368192 
   trunk/ql/src/test/queries/clientpositive/nullscript.q 1368192 
   trunk/ql/src/test/queries/clientpositive/partcols1.q 1368192 
   trunk/ql/src/test/queries/clientpositive/ppd_transform.q 1368192 
   trunk/ql/src/test/queries/clientpositive/query_with_semi.q 1368192 
   trunk/ql/src/test/queries/clientpositive/regexp_extract.q 1368192 
   trunk/ql/src/test/queries/clientpositive/select_transform_hint.q 1368192 
   trunk/ql/src/test/queries/clientpositive/transform_ppr1.q 1368192 
   trunk/ql/src/test/queries/clientpositive/transform_ppr2.q 1368192 
   trunk/ql/src/test/results/clientpositive/input14.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input14_limit.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input17.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input18.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input34.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input35.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input36.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input38.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/input5.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce1.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce2.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce3.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce4.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce7.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/mapreduce8.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/newline.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/nullscript.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/partcols1.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/ppd_transform.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/query_with_semi.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/regexp_extract.q.out 1368192 
   trunk/ql/src/test/results/clientpositive/select_transform_hint.q.out 
 1368192 
   

Review Request: Remove the Unix specific absolute path of “Cat” utility in several .q files to make them run on Windows with CygWin in path.

2012-08-01 Thread Kanna Karanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6313/
---

Review request for hive, Carl Steinbach, Edward  Capriolo, and Ashutosh Chauhan.


Description
---

Several .q files have Unix absolute paths for Cat utility so all of them are 
failing on Windows even with CygWin support. 


This addresses bug HIVE-3327.
https://issues.apache.org/jira/browse/HIVE-3327


Diffs
-

  trunk/contrib/src/test/queries/clientpositive/serde_typedbytes.q 1368192 
  trunk/contrib/src/test/queries/clientpositive/serde_typedbytes2.q 1368192 
  trunk/contrib/src/test/queries/clientpositive/serde_typedbytes3.q 1368192 
  trunk/contrib/src/test/queries/clientpositive/serde_typedbytes4.q 1368192 
  trunk/contrib/src/test/results/clientpositive/serde_typedbytes.q.out 1368192 
  trunk/contrib/src/test/results/clientpositive/serde_typedbytes2.q.out 1368192 
  trunk/contrib/src/test/results/clientpositive/serde_typedbytes3.q.out 1368192 
  trunk/contrib/src/test/results/clientpositive/serde_typedbytes4.q.out 1368192 
  trunk/ql/src/test/queries/clientnegative/clusterbydistributeby.q 1368192 
  trunk/ql/src/test/queries/clientnegative/clusterbyorderby.q 1368192 
  trunk/ql/src/test/queries/clientnegative/clusterbysortby.q 1368192 
  trunk/ql/src/test/queries/clientnegative/orderbysortby.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input14.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input14_limit.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input17.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input18.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input34.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input35.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input36.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input38.q 1368192 
  trunk/ql/src/test/queries/clientpositive/input5.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce1.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce2.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce3.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce4.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce7.q 1368192 
  trunk/ql/src/test/queries/clientpositive/mapreduce8.q 1368192 
  trunk/ql/src/test/queries/clientpositive/newline.q 1368192 
  trunk/ql/src/test/queries/clientpositive/nullscript.q 1368192 
  trunk/ql/src/test/queries/clientpositive/partcols1.q 1368192 
  trunk/ql/src/test/queries/clientpositive/ppd_transform.q 1368192 
  trunk/ql/src/test/queries/clientpositive/query_with_semi.q 1368192 
  trunk/ql/src/test/queries/clientpositive/regexp_extract.q 1368192 
  trunk/ql/src/test/queries/clientpositive/select_transform_hint.q 1368192 
  trunk/ql/src/test/queries/clientpositive/transform_ppr1.q 1368192 
  trunk/ql/src/test/queries/clientpositive/transform_ppr2.q 1368192 
  trunk/ql/src/test/results/clientpositive/input14.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input14_limit.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input17.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input18.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input34.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input35.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input36.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input38.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/input5.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce1.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce2.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce3.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce4.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce7.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/mapreduce8.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/newline.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/nullscript.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/partcols1.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/ppd_transform.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/query_with_semi.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/regexp_extract.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/select_transform_hint.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/transform_ppr1.q.out 1368192 
  trunk/ql/src/test/results/clientpositive/transform_ppr2.q.out 1368192 

Diff: https://reviews.apache.org/r/6313/diff/


Testing
---

Yes.


Thanks,

Kanna Karanam