Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-25 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/#review23858 --- Ship it! Ship It! - Ashutosh Chauhan On July 19, 2013, 6:55

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-19 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/ --- (Updated July 19, 2013, 6:54 p.m.) Review request for hive. Changes ---

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-19 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/ --- (Updated July 19, 2013, 6:55 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-16 Thread Chaoyu Tang
On July 3, 2013, 1:46 a.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2128 https://reviews.apache.org/r/12050/diff/2/?file=314926#file314926line2128 I had quite a discussion on this with Rohini on HIVE-2936 on how to do these fs ops in

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-02 Thread Chaoyu Tang
On July 1, 2013, 6:26 p.m., Sushanth Sowmyan wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2128 https://reviews.apache.org/r/12050/diff/1/?file=310452#file310452line2128 I understand from javadoc that FileStatus.isDirectory() is supposed to be the new way

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-02 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/ --- (Updated July 2, 2013, 4:39 p.m.) Review request for hive. Changes ---

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/#review22698 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-01 Thread Sushanth Sowmyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12050/#review22617 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Re: Review Request 12050: HIVE-3756 (LOAD DATA does not honor permission inheritance)

2013-07-01 Thread Sushanth Sowmyan
On July 1, 2013, 6:26 p.m., Sushanth Sowmyan wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2128 https://reviews.apache.org/r/12050/diff/1/?file=310452#file310452line2128 I understand from javadoc that FileStatus.isDirectory() is supposed to be the new way