Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-09-12 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/#review26066 --- Ship it! Ship It! - Jakob Homan On Aug. 30, 2013, 11:49 a.m.,

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-08-30 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/ --- (Updated Aug. 30, 2013, 6:49 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-08-30 Thread Mohammad Islam
On Aug. 26, 2013, 5:35 a.m., Jakob Homan wrote: serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java, line 529 https://reviews.apache.org/r/12480/diff/3/?file=338097#file338097line529 Weird spacing... 2x below as well. Done On Aug. 26, 2013, 5:35 a.m.,

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-08-25 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/#review25537 --- One issue in the testing and a few formatting issues. Otherwise

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-08-06 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/ --- (Updated Aug. 7, 2013, 2:13 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-07-15 Thread Mohammad Islam
On July 12, 2013, 10:44 p.m., Jakob Homan wrote: Do you have after-optimization performance numbers? Can you add a test to verify that the reencoder cache is working correctly? Feed in a record with one uuid, then another with a different and verify that the cache has two elements.

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-07-15 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/ --- (Updated July 15, 2013, 11:48 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-07-12 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/#review23113 --- Do you have after-optimization performance numbers? Can you add a

Review Request 12480: HIVE-4732 Reduce or eliminate the expensive Schema equals() check for AvroSerde

2013-07-11 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12480/ --- Review request for hive, Ashutosh Chauhan and Jakob Homan. Bugs: HIVE-4732