Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/ --- Review request for hive. Bugs: HIVE-4877

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/#review23531 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/#review23541 --- Ship it! Ship It! - Ashutosh Chauhan On July 19, 2013, 7:04

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Yin Huai
On July 19, 2013, 6:02 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java, lines 229-231 https://reviews.apache.org/r/12767/diff/1/?file=323660#file323660line229 I didn't get why there is an if check here? Can you add a comment explaining

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/ --- (Updated July 19, 2013, 7:04 p.m.) Review request for hive. Changes ---

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/ --- (Updated July 19, 2013, 8:48 p.m.) Review request for hive. Changes ---

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12767/#review23527 --- Good work, Yin! some minor comments.

Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side

2013-07-19 Thread Yin Huai
On July 19, 2013, 6:25 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java, line 299 https://reviews.apache.org/r/12767/diff/1/?file=323661#file323661line299 Should we also add following in comment? .. and directly call process on children