Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-09-02 Thread Yin Huai
On Sept. 2, 2013, 5:39 a.m., Yin Huai wrote: Another sanity check. Done. - Yin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13862/#review25819

Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-09-02 Thread Yin Huai
On Sept. 2, 2013, 5:29 a.m., Yin Huai wrote: Thanks for adding comments! We can have a query like ... explain select * from (select * from src1 cluster by key) tmp sort by key, value; In this case, at first, we have two MR jobs. Since the second job is used for sort by. There is no

Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-09-02 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13862/ --- (Updated Sept. 3, 2013, 12:29 a.m.) Review request for hive. Changes ---

Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-09-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13862/#review25818 ---

Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-09-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13862/#review25819 ---

Re: Review Request 13862: [HIVE-5149] ReduceSinkDeDuplication can pick the wrong partitioning columns

2013-08-30 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13862/ --- (Updated Aug. 30, 2013, 3:29 p.m.) Review request for hive. Summary