Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-28 Thread Prasad Mujumdar
On Feb. 18, 2014, 6:41 p.m., Prasad Mujumdar wrote: @Vaibhav, thanks for the patch and following up on the overall async execution line items! The patch itself looks fine on the first pass. I do have a high level question on the approach. The patch enables async execution by

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-28 Thread Vaibhav Gumashta
On Feb. 23, 2014, 12:36 a.m., Thejas Nair wrote: jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 271 https://reviews.apache.org/r/14950/diff/3/?file=498672#file498672line271 I think we should retry on exceptions that indicate an network connection error.

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-28 Thread Vaibhav Gumashta
On Feb. 18, 2014, 6:41 p.m., Prasad Mujumdar wrote: @Vaibhav, thanks for the patch and following up on the overall async execution line items! The patch itself looks fine on the first pass. I do have a high level question on the approach. The patch enables async execution by

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/ --- (Updated March 1, 2014, 12:43 a.m.) Review request for hive, Prasad Mujumdar

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-27 Thread Thejas Nair
On Feb. 18, 2014, 6:41 p.m., Prasad Mujumdar wrote: @Vaibhav, thanks for the patch and following up on the overall async execution line items! The patch itself looks fine on the first pass. I do have a high level question on the approach. The patch enables async execution by

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-27 Thread Thejas Nair
On Feb. 23, 2014, 12:36 a.m., Thejas Nair wrote: jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 271 https://reviews.apache.org/r/14950/diff/3/?file=498672#file498672line271 I think we should retry on exceptions that indicate an network connection error.

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-22 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/#review35234 --- jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-20 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/ --- (Updated Feb. 20, 2014, 9:18 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-18 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/ --- (Updated Feb. 18, 2014, 2:22 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-18 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/#review34728 --- @Vaibhav, thanks for the patch and following up on the overall

Re: Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2014-02-18 Thread Vaibhav Gumashta
On Feb. 18, 2014, 6:41 p.m., Prasad Mujumdar wrote: @Vaibhav, thanks for the patch and following up on the overall async execution line items! The patch itself looks fine on the first pass. I do have a high level question on the approach. The patch enables async execution by

Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2013-10-25 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14950/ --- Review request for hive and Thejas Nair. Repository: hive-git Description