---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review41772
---
On April 6, 2014, 4:32 a.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ColumnMappings.java,
line 40
https://reviews.apache.org/r/18179/diff/8/?file=544996#file544996line40
I think I had a previous comment that hasn't been addressed. It'
scopied
On April 6, 2014, 4:32 a.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java,
line 98
https://reviews.apache.org/r/18179/diff/8/?file=544997#file544997line98
Can we pass those as constructor arguments instead of individual set
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review39628
---
Patch looks good, except that I'm not quite sure if I fully
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated April 2, 2014, 6:28 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review39179
---
- Xuefu Zhang
On April 1, 2014, 12:59 a.m., Navis Ryu wrote:
On March 25, 2014, 6:38 p.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseAbstractKeyFactory.java,
line 31
https://reviews.apache.org/r/18179/diff/6/?file=535090#file535090line31
Do you think AbstractHBaseKeyFactory is slightly better?
Navis Ryu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review38496
---
On March 25, 2014, 6:38 p.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseAbstractKeyFactory.java,
line 31
https://reviews.apache.org/r/18179/diff/6/?file=535090#file535090line31
Do you think AbstractHBaseKeyFactory is slightly better?
Yes, it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated April 1, 2014, 12:59 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated March 25, 2014, 8:02 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review38465
---
On March 10, 2014, 9:25 p.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java, line
730
https://reviews.apache.org/r/18179/diff/5/?file=513392#file513392line730
Can we define serielize() interface in HBaseKeyFactory, move the
existing
On March 10, 2014, 9:25 p.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java, line
730
https://reviews.apache.org/r/18179/diff/5/?file=513392#file513392line730
Can we define serielize() interface in HBaseKeyFactory, move the
existing
On March 10, 2014, 9:25 p.m., Xuefu Zhang wrote:
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 702
https://reviews.apache.org/r/18179/diff/5/?file=513405#file513405line702
Do these methods have to be public? Private if just used locally.
Navis Ryu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review36688
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review36711
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review36719
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review36720
---
On March 10, 2014, 9:25 p.m., Xuefu Zhang wrote:
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 702
https://reviews.apache.org/r/18179/diff/5/?file=513405#file513405line702
Do these methods have to be public? Private if just used locally.
Seemed to find use case
On March 10, 2014, 10:22 p.m., Swarnim Kulkarni wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseScanRange.java,
line 100
https://reviews.apache.org/r/18179/diff/4/?file=513316#file513316line100
I think we are restricting the capability here by limiting the type of
On March 10, 2014, 9:25 p.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java, line
730
https://reviews.apache.org/r/18179/diff/5/?file=513392#file513392line730
Can we define serielize() interface in HBaseKeyFactory, move the
existing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated March 7, 2014, 3:32 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review36493
---
Looks good, though I haven't finished review yet. Here are some
On March 7, 2014, 6:22 a.m., Xuefu Zhang wrote:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseWritableKeyFactory.java,
line 26
https://reviews.apache.org/r/18179/diff/4/?file=513319#file513319line26
Don't we expect this key type handles predicate pushdown?
Firstly it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated March 7, 2014, 7:46 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated March 5, 2014, 3:47 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
(Updated March 4, 2014, 1:44 a.m.)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/
---
Review request for hive.
Bugs: HIVE-6411
29 matches
Mail list logo
