Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Amareshwari Sriramadasu
> On March 2, 2016, 5:53 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java, > > line 178 > > > > > > I assume you only allow F to be a constant string.

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/ --- (Updated March 3, 2016, 6:19 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/#review121679 ---

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2016-03-01 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/ --- (Updated March 1, 2016, 11:01 p.m.) Review request for hive, Ashutosh Chauhan,

Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2014-02-17 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/ --- Review request for hive, Ashutosh Chauhan and Navis Ryu. Bugs: HIVE-5370

Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument

2014-02-17 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18182/ --- (Updated Feb. 18, 2014, 4:25 a.m.) Review request for hive, Ashutosh Chauhan