Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-28 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/ --- (Updated March 28, 2014, 9:56 p.m.) Review request for hive and Eric Hanson.

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-28 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/#review38958 ---

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-28 Thread Jitendra Pandey
On March 28, 2014, 10:42 p.m., Eric Hanson wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java, line 62 https://reviews.apache.org/r/19718/diff/3/?file=539988#file539988line62 please add a comment to explain why we use the sum of all the counts

Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-27 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/ --- Review request for hive and Eric Hanson. Bugs: HIVE-6752

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-27 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/#review38752 --- Looks good overall. Only minor comments.

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-27 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/ --- (Updated March 27, 2014, 11:22 p.m.) Review request for hive and Eric Hanson.