Review Request 21016: Deprecate class and remove tests.

2014-05-02 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21016/
---

Review request for hive and Jason Dere.


Bugs: HIVE-7008
https://issues.apache.org/jira/browse/HIVE-7008


Repository: hive-git


Description
---

Marked class as Deprecated.
Removed tests for now obsolete functionality.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/io/FlatFileInputFormat.java b9b151a 
  ql/src/test/org/apache/hadoop/hive/ql/io/RecordTestObj.java 1bb846b 
  ql/src/test/org/apache/hadoop/hive/ql/io/TestFlatFileInputFormat.java c46d754 

Diff: https://reviews.apache.org/r/21016/diff/


Testing
---


Thanks,

Ashutosh Chauhan



Re: Review Request 21016: Deprecate class and remove tests.

2014-05-02 Thread Jason Dere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21016/#review42045
---


Also delete JavaTestObjFlatFileInputFormat which is being used by the deleted 
test.

- Jason Dere


On May 2, 2014, 6:19 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21016/
 ---
 
 (Updated May 2, 2014, 6:19 p.m.)
 
 
 Review request for hive and Jason Dere.
 
 
 Bugs: HIVE-7008
 https://issues.apache.org/jira/browse/HIVE-7008
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Marked class as Deprecated.
 Removed tests for now obsolete functionality.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/io/FlatFileInputFormat.java b9b151a 
   ql/src/test/org/apache/hadoop/hive/ql/io/RecordTestObj.java 1bb846b 
   ql/src/test/org/apache/hadoop/hive/ql/io/TestFlatFileInputFormat.java 
 c46d754 
 
 Diff: https://reviews.apache.org/r/21016/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 21016: Deprecate class and remove tests.

2014-05-02 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21016/
---

(Updated May 2, 2014, 11:24 p.m.)


Review request for hive and Jason Dere.


Changes
---

Incorporated Jason feedback to delete another test file.


Bugs: HIVE-7008
https://issues.apache.org/jira/browse/HIVE-7008


Repository: hive-git


Description
---

Marked class as Deprecated.
Removed tests for now obsolete functionality.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/io/FlatFileInputFormat.java b9b151a 
  ql/src/test/org/apache/hadoop/hive/ql/io/JavaTestObjFlatFileInputFormat.java 
830ecef 
  ql/src/test/org/apache/hadoop/hive/ql/io/RecordTestObj.java 1bb846b 
  ql/src/test/org/apache/hadoop/hive/ql/io/TestFlatFileInputFormat.java c46d754 

Diff: https://reviews.apache.org/r/21016/diff/


Testing
---


Thanks,

Ashutosh Chauhan