Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 20, 2014, 3:50 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, > > line 284 > > > > > > doesn't this need to be done for other Operation sub classes ?

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/ --- (Updated Aug. 26, 2014, 8:24 a.m.) Review request for hive. Changes ---

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/if/TCLIService.thrift, line 1043 > > > > > > I know that no one else does it yet in this file and I haven't gotten > > around to finishing my patch. > >

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review51230 --- service/if/TCLIService.thrift

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review51071 --- service/src/test/org/apache/hive/service/cli/operation/TestOperatio

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review51047 --- service/src/java/org/apache/hive/service/cli/ICLIService.java

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review50977 --- Hi, This patch looks really good! I was not clear when I said how w

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/ --- (Updated Aug. 14, 2014, 3:09 p.m.) Review request for hive. Changes ---

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 12, 2014, 4:54 p.m., Brock Noland wrote: > > Hi Dong! Excellent work! I have given it a first review and I think it > > looks great. I have some initial feedback below. Hi Brock, thanks for your review and the comments are very useful. I update the patch based on them and leave some

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review50335 --- Hi Dong! Excellent work! I have given it a first review and I think

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/src/java/org/apache/hive/service/cli/operation/OperationLog.java, > > line 58 > > > > > > can be final and then renamed > > Dong Chen wrote: > Thank yo

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/ --- (Updated Aug. 7, 2014, 5:37 p.m.) Review request for hive. Changes --- A

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 7, 2014, 4:57 p.m., Lars Francke wrote: > > service/if/TCLIService.thrift, line 1043 > > > > > > I have a partial patch that changes all of them and I planned on > > submitting it when I'm back from holiday

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/ --- (Updated Aug. 7, 2014, 5:06 p.m.) Review request for hive. Changes --- U

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 7, 2014, 4:57 p.m., Lars Francke wrote: > > service/if/TCLIService.thrift, line 1043 > > > > > > I have a partial patch that changes all of them and I planned on > > submitting it when I'm back from holiday

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/src/java/org/apache/hive/service/cli/operation/OperationLog.java, > > line 58 > > > > > > can be final and then renamed > > Dong Chen wrote: > Thank yo

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review49911 --- service/if/TCLIService.thrift

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/src/java/org/apache/hive/service/cli/operation/OperationLog.java, > > line 58 > > > > > > can be final and then renamed Thank you! I made it final and it i

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java, > > line 81 > > > > > > I don't understand how log data ends up in the writer? I look

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

> On Aug. 5, 2014, 8:56 a.m., Lars Francke wrote: > > service/if/TCLIService.thrift, line 1043 > > > > > > I know that no one else does it yet in this file and I haven't gotten > > around to finishing my patch. > >

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review49573 --- Thanks for taking care of this patch. I think the interface design l

Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review49563 --- This is awesome! I have two minor comments and I will let others do

Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/ --- Review request for hive. Repository: hive-git Description --- HIVE-4629: