Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

2015-06-05 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35136/ --- Review request for hive. Repository: hive-git Description ---

Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

2015-06-05 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35136/#review86824 --- data/files/emp2.txt

Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

2015-06-05 Thread Aihua Xu
On June 5, 2015, 6:22 p.m., Ashutosh Chauhan wrote: data/files/emp2.txt, line 1 https://reviews.apache.org/r/35136/diff/1/?file=979976#file979976line1 Can you add few rows with NULL value for date column? Want to make sure DateValueBoundaryScanner.isGreater() and isEqual()

Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

2015-06-05 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35136/ --- (Updated June 5, 2015, 8:42 p.m.) Review request for hive. Repository: