Re: Review Request 38940: unable to create temporary table using CTAS if regular table with that name already exists

2015-10-05 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38940/#review101559
---

Ship it!


Ship It!

- John Pullokkaran


On Oct. 1, 2015, 10:50 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38940/
> ---
> 
> (Updated Oct. 1, 2015, 10:50 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CTAS temporary table query fails if regular table with the same name already 
> exists. 
> Steps to reproduce the issue:
> {noformat}
> hive> use dbtemptable;
> OK
> Time taken: 0.273 seconds
> hive> create table a(i int);
> OK
> Time taken: 0.297 seconds
> hive> create temporary table a(i int);
> OK
> Time taken: 0.165 seconds
> hive> create table b(i int);
> OK
> Time taken: 0.212 seconds
> hive> create temporary table b as select * from a;
> FAILED: SemanticException org.apache.hadoop.hive.ql.parse.SemanticException: 
> Table already exists: dbtemptable.b
> hive> create table c(i int);
> OK
> Time taken: 0.264 seconds
> hive> create temporary table b as select * from c;
> FAILED: SemanticException org.apache.hadoop.hive.ql.parse.SemanticException: 
> Table already exists: dbtemptable.b
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
>  51ff262 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4bec228 
>   ql/src/test/queries/clientpositive/temp_table.q e587f3f 
>   ql/src/test/results/clientpositive/spark/temp_table.q.out 65e256d 
>   ql/src/test/results/clientpositive/temp_table.q.out e2987fe 
>   ql/src/test/results/clientpositive/tez/temp_table.q.out 49f57c2 
> 
> Diff: https://reviews.apache.org/r/38940/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>



Review Request 38940: unable to create temporary table using CTAS if regular table with that name already exists

2015-10-01 Thread pengcheng xiong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38940/
---

Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Repository: hive-git


Description
---

CTAS temporary table query fails if regular table with the same name already 
exists. 
Steps to reproduce the issue:
{noformat}
hive> use dbtemptable;
OK
Time taken: 0.273 seconds
hive> create table a(i int);
OK
Time taken: 0.297 seconds
hive> create temporary table a(i int);
OK
Time taken: 0.165 seconds
hive> create table b(i int);
OK
Time taken: 0.212 seconds
hive> create temporary table b as select * from a;
FAILED: SemanticException org.apache.hadoop.hive.ql.parse.SemanticException: 
Table already exists: dbtemptable.b
hive> create table c(i int);
OK
Time taken: 0.264 seconds
hive> create temporary table b as select * from c;
FAILED: SemanticException org.apache.hadoop.hive.ql.parse.SemanticException: 
Table already exists: dbtemptable.b
{noformat}


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 
51ff262 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4bec228 
  ql/src/test/queries/clientpositive/temp_table.q e587f3f 
  ql/src/test/results/clientpositive/spark/temp_table.q.out 65e256d 
  ql/src/test/results/clientpositive/temp_table.q.out e2987fe 
  ql/src/test/results/clientpositive/tez/temp_table.q.out 49f57c2 

Diff: https://reviews.apache.org/r/38940/diff/


Testing
---


Thanks,

pengcheng xiong