Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-23 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- (Updated June 23, 2016, 9:36 p.m.) Review request for hive, Mohit Sabharwal

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread Szehon Ho
> On June 17, 2016, 10:20 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3179 > > > > > > I actually meant here to get rid of these checks as well (in

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Sergio Pena
> On June 17, 2016, 10:20 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3179 > > > > > > I actually meant here to get rid of these checks as well (in

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review138113 --- Looks good to me. Just a follow up on the previous comment, can

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- (Updated June 17, 2016, 3:18 p.m.) Review request for hive, Mohit Sabharwal

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Sergio Pena
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 780 > > > > > > Should we add this to 'metaVars' variable? Reading the doc, it seems > > it will

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review138081 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 780 > > > > > > Should we add this to 'metaVars' variable? Reading the doc, it seems > > it will

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Sergio Pena
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 780 > > > > > > Should we add this to 'metaVars' variable? Reading the doc, it seems > > it will

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 4793 > > > > > > Should fix this? Clarify: fix the name. - Szehon

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > Mostly looks good, just some nits. - Szehon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review138089

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review138089 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- (Updated June 16, 2016, 4:04 p.m.) Review request for hive, Mohit Sabharwal

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-15 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- (Updated June 15, 2016, 8:45 p.m.) Review request for hive, Mohit Sabharwal

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-15 Thread Sergio Pena
> On June 14, 2016, 1:29 a.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3179 > > > > > > Since we are moving the functionality from driver to HMS,

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review137434 --- LGTM, but couple comments regarding breaking backward

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- (Updated June 13, 2016, 6:28 p.m.) Review request for hive, Mohit Sabharwal

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena
> On June 9, 2016, 3:18 p.m., Reuben Kuhnert wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line > > 2830 > > > > > > Maybe StringUtils.isEmpty? I think it will do both of these

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena
> On June 10, 2016, 4:31 a.m., Kapil Rastogi wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3176 > > > > > > what is the default for getIntVar if the configuration

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-09 Thread Kapil Rastogi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review136927 ---

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-09 Thread Reuben Kuhnert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#review136810 --- Fix it, then Ship it! Mostly minor cleanup nitpicks. Might

Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-03 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/ --- Review request for hive and Mohit Sabharwal. Bugs: HIVE-13884