Re: Review Request 48500: HIVE-13982

2016-06-24 Thread Ashutosh Chauhan
> On June 23, 2016, 3 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/reduce_deduplicate_extended2.q, line 3 > > > > > > We need to explore this further, since auto convert join is on by > >

Re: Review Request 48500: HIVE-13982

2016-06-24 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 24, 2016, 11:34 p.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-24 Thread Jesús Camacho Rodríguez
> On June 23, 2016, 3 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelCollationPropagator.java, > > line 117 > > > > > > I may be wrong, but doesn't this mean

Re: Review Request 48500: HIVE-13982

2016-06-23 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/#review139251 ---

Re: Review Request 48500: HIVE-13982

2016-06-22 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 22, 2016, 8:27 p.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 21, 2016, 5:28 p.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-20 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 21, 2016, 3:44 a.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-15 Thread Jesús Camacho Rodríguez
> On June 15, 2016, 3:23 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java, > > line 247 > > > > > > Can you add a comment that why we don't care

Re: Review Request 48500: HIVE-13982

2016-06-15 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/#review137744 ---

Re: Review Request 48500: HIVE-13982

2016-06-13 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 13, 2016, 12:06 p.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-10 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 10, 2016, 5:45 p.m.) Review request for hive and Ashutosh

Re: Review Request 48500: HIVE-13982

2016-06-10 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- (Updated June 10, 2016, 5:44 p.m.) Review request for hive and Ashutosh

Review Request 48500: HIVE-13982

2016-06-09 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48500/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-13982