Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review142322 --- Ship it! Ship It! - Mohit Sabharwal On July 14, 2016, 11:12

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/ --- (Updated July 14, 2016, 11:12 p.m.) Review request for hive, Mohit Sabharwal, S

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Mohit Sabharwal
> On July 14, 2016, 9:57 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BufferedRows.java, line 76 > > > > > > Thanks for reviewing. I thought of adding it in the above loop like you >

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review142292 --- beeline/src/java/org/apache/hive/beeline/BufferedRows.java (line

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review142287 --- beeline/src/java/org/apache/hive/beeline/BufferedRows.java (line

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-12 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/ --- (Updated July 12, 2016, 5:51 p.m.) Review request for hive, Mohit Sabharwal, Se

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-12 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review141920 --- I took a look at the unit test and the use of Mockito, the approac

Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-11 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/ --- Review request for hive, Mohit Sabharwal, Sergio Pena, Sahil Takiar, and Thejas