Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/#review147610 --- Ship it! Think there's several issues which still need

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java, > > line 554 > > > > > > The size of this collection is used

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:36 p.m., Siddharth Seth wrote: > > Unrelated to this patch - Any idea why 'uniq' is static/ (private static > > final UUID uniq = UUID.randomUUID();) > > Sergey Shelukhin wrote: > it's daemon identity, so it's global per daemon Why is the daemon identity a static?

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/ --- (Updated Sept. 1, 2016, 6:35 p.m.) Review request for hive and Prasanth_J.

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java, > > line 561 > > > > > > Here, as well as other places, a

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/#review147548 --- Will look at the updated patch tomorrow. - Siddharth Seth On

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java, > > line 538 > > > > > > There's a lot of similar code to

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/#review147499 ---

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/ --- (Updated Aug. 31, 2016, 10:25 p.m.) Review request for hive and Prasanth_J.

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestHostAffinitySplitLocationProvider.java, > > line 98 > > > > > > This isn't part of the patch uploaded to

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:36 p.m., Siddharth Seth wrote: > > Unrelated to this patch - Any idea why 'uniq' is static/ (private static > > final UUID uniq = UUID.randomUUID();) it's daemon identity, so it's global per daemon - Sergey ---

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java, > > line 104 > > > > > > Move this into a separate path

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/#review147377 --- Unrelated to this patch - Any idea why 'uniq' is static/ (private

Re: Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/#review147362 --- Possible to add a test (or a few)? (I don' see one in the patch

Review Request 51312: HIVE-14589 add consistent node replacement to LLAP for splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51312/ --- Review request for hive and Prasanth_J. Repository: hive-git Description