Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Sept. 1, 2016, 7:12 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 31, 2016, 11:58 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 26, 2016, 12:23 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 26, 2016, 2:38 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 25, 2016, 10:46 p.m., Zoltan Haindrich wrote: > > This patch is huge...it was very time consuming doing its review - it would > > have been much better to split some of it into smaller changes Hi Zoltan, I know it is a big patch, and I appreciate your review very much, however I did

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146909 --- Not a lot here related to the patch itself in this comment. Looks

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 25, 2016, 10 p.m., Gabor Szadovszky wrote: > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java, > > line 39 > > > > > > Might worth to have the same explanation as you've had

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 25, 2016, 11:24 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

> On Aug. 25, 2016, 4:55 p.m., Barna Zsombor Klara wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java, line > > 2276 > > > > > > Nit: Can we decide on whether to use System.out or

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146818 --- This patch is huge...it was very time consuming doing its review

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146857 --- 1 major & 1 minor comments. Otherwise, LGTM. Great work, thanks a

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146792 ---

Review Request 51397: HIVE-14536 Unit test code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- Review request for hive, Ashutosh Chauhan, Gabor Szadovszky, Zoltan Haindrich,