Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review160177 --- Ship it! Ship It! - Thejas Nair On Dec. 27, 2016, 4:44

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-27 Thread Daniel Dai
> On Dec. 27, 2016, 6:26 a.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, > > line 55 > > > > > > seems better as local to the reycle method, as its not used

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-27 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/ --- (Updated Dec. 27, 2016, 4:44 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Daniel Dai
> On Dec. 27, 2016, 6:26 a.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, > > line 55 > > > > > > seems better as local to the reycle method, as its not used

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/ --- (Updated Dec. 27, 2016, 6:55 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-26 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review160135 ---

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-23 Thread Daniel Dai
> On Dec. 20, 2016, 8:56 p.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, > > line 175 > > > > > > is there any generic way to find this from FileSystem api ?

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-23 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/ --- (Updated Dec. 23, 2016, 8:29 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-20 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review159520 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line

Review Request 54826: HIVE-15448: ChangeManager for replication

2016-12-16 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/ --- Review request for hive and Thejas Nair. Repository: hive-git Description