Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-23 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/ --- (Updated Feb. 23, 2017, 7:57 p.m.) Review request for hive. Changes ---

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-23 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/ --- (Updated Feb. 23, 2017, 7:37 p.m.) Review request for hive. Changes ---

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-23 Thread Sergio Pena
> On Feb. 22, 2017, 6:04 p.m., Illya Yalovyy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2081 > > > > > > I feel like we need a unit test for this method. Agree. It is a private metho

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-22 Thread Illya Yalovyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166384 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (line 2

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-22 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/ --- (Updated Feb. 22, 2017, 4:28 p.m.) Review request for hive. Changes ---

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-22 Thread Sergio Pena
> On Feb. 21, 2017, 10:41 p.m., Thomas Poepping wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2085 > > > > > > The default is already defined in HiveConf, right? Do we need to > > spe

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Sergey Shelukhin
> On Feb. 21, 2017, 10:41 p.m., Thomas Poepping wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2085 > > > > > > The default is already defined in HiveConf, right? Do we need to > > spe

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166274 --- LGTM. Thanks for the patch Sergio! - Vihang Karajgaonkar On Feb

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Sergio Pena
> On Feb. 21, 2017, 10:41 p.m., Thomas Poepping wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 2085 > > > > > > The default is already defined in HiveConf, right? Do we need to > > spe

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Thomas Poepping
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166250 --- Otherwise LGTM ql/src/java/org/apache/hadoop/hive/ql/exec/Utilit

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/ --- (Updated Feb. 21, 2017, 9:01 p.m.) Review request for hive. Changes ---

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-14 Thread Thomas Poepping
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review165645 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines

Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-14 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/ --- Review request for hive. Bugs: HIVE-15881 https://issues.apache.org/jira/br