Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review170943 --- Ship it! Ship It! - Mohit Sabharwal On April 3, 2017, 10:34

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated April 3, 2017, 10:34 p.m.) Review request for hive. Changes ---

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > > Lines 51-52 (patched) > > > > > > What's the point of have duplicate

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > > Lines 51-52 (patched) > > > > > > What's the point of have duplicate

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > > Lines 51-52 (patched) > > > > > > What's the point of have duplicate

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > > Lines 51-52 (patched) > > > > > > What's the point of have duplicate

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote: > > hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java > > Lines 487 (patched) > > > > > > I didn't mean

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review170576 ---

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated March 28, 2017, 3:17 p.m.) Review request for hive. Bugs:

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review170257 --- Fix it, then Ship it! Ship It!

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated March 24, 2017, 10:23 p.m.) Review request for hive. Changes

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 23, 2017, 12:27 a.m., Alexander Kolbasov wrote: > > This is good, but I am wondering what is the purpose in using different > > events between transactional and non-transactional listeners in most cases? > > It would be much simpler and cleaner to reuse existing event except for one

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review169801 --- This is good, but I am wondering what is the purpose in using

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 17, 2017, 10:34 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java > > Lines 138 (patched) > > > > > > I agree with Alexander. We can avoid

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review169602 ---

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated March 20, 2017, 10:33 p.m.) Review request for hive. Changes

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 17, 2017, 10:34 p.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 2476 (original), 2484 (patched) > > > > > > I like the idea of keeping

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review169320 ---

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated March 17, 2017, 8:14 p.m.) Review request for hive. Changes ---

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 17, 2017, 1:28 a.m., Alexander Kolbasov wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > > Line 33 (original), 37 (patched) > > > > > > Status isn't realy a

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> On March 17, 2017, 1:28 a.m., Alexander Kolbasov wrote: > > hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java > > Lines 80 (patched) > > > > > > Do you

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review169238 --- I like the idea of adding generic parameters to the event. It

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- (Updated March 16, 2017, 10:36 p.m.) Review request for hive. Changes

Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ --- Review request for hive. Bugs: HIVE-16164