Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-06 Thread Vineet Garg
> On Nov. 7, 2017, 12:03 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 1790-1792 (original) > > > > > > I checked and this rule does look useful. Maybe

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-06 Thread Vineet Garg
> On Nov. 2, 2017, 4:40 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/subquery_multi.q.out > > Lines 2947-2950 (patched) > > > > > > Extra scan and Gby. The ordering is a bit different

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-06 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/#review190247 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-06 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/ --- (Updated Nov. 6, 2017, 7:53 p.m.) Review request for hive and Ashutosh

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/#review189924 --- ql/src/test/results/clientpositive/llap/subquery_in.q.out Lines

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-01 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/ --- (Updated Nov. 2, 2017, 4:51 a.m.) Review request for hive and Ashutosh

Re: Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/#review189825 ---

Review Request 63470: HIVE-17767 Rewrite correlated EXISTS/IN subqueries into LEFT SEMI JOIN

2017-11-01 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63470/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-17767