Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197072 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Feb. 8, 2018,

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 9 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > I am not sure what we do with duplicates, there

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 8, 2018, 12:44 a.m.) Review request for hive and Jesús Camacho Ro

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197037 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Feb. 7, 2018, 8:31 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 3891 (patched) > > > > > > The check should be on _groupByExpr.size()_?

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197026 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 7, 2018, 8:21 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review197017 --- Could we add an error message at compilation time for grouping set

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Feb. 7, 2018, 7:15 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review196518 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Lines 6

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 9, 2018, 10:30 a.m., Zoltan Haindrich wrote: > > ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out > > Lines 111 (patched) > > > > > > there should be no result set changes in this q.out >

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Jan. 30, 2018, 8:31 a.m.) Review request for hive and Jesús Camacho Ro

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review195063 --- ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.ou

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review195020 --- ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.ou

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 63 (original), 63 (patched) > > > > > > I think it should be sufficie

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 63 (original), 63 (patched) > > > > > > I think it should be sufficie

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Jan. 5, 2018, 6:55 a.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 63 (original), 63 (patched) > > > > > > I think it should be sufficie

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 63 (original), 63 (patched) > > > > > > I think it should be sufficie

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 50 (original), 50 (patched) > > > > > > Return value for Grouping fun

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 50 (original), 50 (patched) > > > > > > Return value for Grouping fun

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java > > Line 50 (original), 50 (patched) > > > > > > Return value for Grouping fun

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/#review194829 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGroup

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Jan. 5, 2018, 3:32 a.m.) Review request for hive and Jesús Camacho Rod

Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- Review request for hive and Jesús Camacho Rodríguez. Repository: hive-git Des

Re: Review Request 64900: HIVE-18359: Extend grouping set limits from int to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64900/ --- (Updated Jan. 3, 2018, 12:04 a.m.) Review request for hive and Jesús Camacho Ro