Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-04-03 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated April 3, 2018, 7:48 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
08d26dc14e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 
3ed793ec48 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/7/

Changes: https://reviews.apache.org/r/66201/diff/6-7/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-04-02 Thread Jason Dere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review200326
---




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Lines 117 (patched)


clean up whitespace.


- Jason Dere


On April 2, 2018, 10:13 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> ---
> 
> (Updated April 2, 2018, 10:13 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
> a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> ed1c0abdf2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 
> 3ed793ec48 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-04-02 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review200323
---




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Line 81 (original), 86 (patched)


outdated comment


- Sergey Shelukhin


On April 2, 2018, 10:13 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> ---
> 
> (Updated April 2, 2018, 10:13 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
> a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> ed1c0abdf2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 
> 3ed793ec48 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-04-02 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated April 2, 2018, 10:13 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 02367eb433 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
ed1c0abdf2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 
3ed793ec48 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/6/

Changes: https://reviews.apache.org/r/66201/diff/5-6/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-29 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated March 29, 2018, 8:04 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 697b1940a9 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1de333e985 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a5f4cb7539 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
74c271d80b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLoggedInUser.java 
3ed793ec48 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/5/

Changes: https://reviews.apache.org/r/66201/diff/4-5/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-28 Thread Jason Dere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review200158
---




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
Lines 170 (patched)


nit



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
Lines 249 (patched)


Might want to confirm with Thejas on the appropriate method to use - it 
might be Sessionstate.getUserFromAuthenticator()


- Jason Dere


On March 28, 2018, 12:18 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> ---
> 
> (Updated March 28, 2018, 12:18 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5888eaa6fb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
> a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
> PRE-CREATION 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-27 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated March 28, 2018, 12:18 a.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5888eaa6fb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5cd4f 


Diff: https://reviews.apache.org/r/66201/diff/4/

Changes: https://reviews.apache.org/r/66201/diff/3-4/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-23 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated March 23, 2018, 9:44 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66201/diff/3/

Changes: https://reviews.apache.org/r/66201/diff/2-3/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-23 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/#review199913
---




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Lines 42 (patched)


whitespace


- Sergey Shelukhin


On March 23, 2018, 9:40 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66201/
> ---
> 
> (Updated March 23, 2018, 9:40 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
> a051f90195 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66201/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-23 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

(Updated March 23, 2018, 9:40 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66201/diff/2/

Changes: https://reviews.apache.org/r/66201/diff/1-2/


Testing
---


Thanks,

Sergey Shelukhin

Review Request 66201: HIVE-19014 utilize YARN-8028 (queue ACL check) in Hive Tez session pool

2018-03-21 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66201/
---

Review request for hive and Thejas Nair.


Repository: hive-git


Description
---

see jira


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
a051f90195 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66201/diff/1/


Testing
---


Thanks,

Sergey Shelukhin