Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-10-08 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209313 ---

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-10-01 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 11:20 p.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 918 (patched) > > > > > > You

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-10-01 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- (Updated Oct. 2, 2018, 5:19 a.m.) Review request for hive and Alexander

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-10-01 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > > Line 297 (original), 310 (patched) > >

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-30 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- (Updated Sept. 30, 2018, 6:55 p.m.) Review request for hive and Alexander

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209102 ---

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- (Updated Sept. 28, 2018, 4:59 p.m.) Review request for hive and Alexander

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Andrew Sherman via Review Board
> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 917 (patched) > > > > > > make

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > > Lines 66 (patched) > > > > > > add test with the

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- (Updated Sept. 28, 2018, 10:17 a.m.) Review request for hive and Alexander

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 11:20 p.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > > Lines 44 (patched) > > > > > > It would be

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 11:20 p.m., Alexander Kolbasov wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 917 (patched) > > > > > > I

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 913 (patched) > > > > > > Good

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

2018-09-28 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ --- (Updated Sept. 28, 2018, 9:38 a.m.) Review request for hive and Alexander