Re: Review Request 68895: HadoopVer was ignored in QTestUtil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/#review209270 --- Ship it! Ship It! - Janaki Lahorani On Oct. 5, 2018, 10 a.m., denys kuzmenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68895/ > --- > > (Updated Oct. 5, 2018, 10 a.m.) > > > Review request for hive, Zoltan Haindrich and Peter Vary. > > > Bugs: HIVE-20647 > https://issues.apache.org/jira/browse/HIVE-20647 > > > Repository: hive-git > > > Description > --- > > - Removed obsolete hadoopVer from QTestUtil > > - Cleaned up QTestUtil, QTestArgumentsBuilder > > - Refactored AccumuloTestSetup, AccumuloQTestUtil due to findbugs violation: > (UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR: Uninitialized read of > field method called from constructor of superclass) > > > Diffs > - > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java > b7e563aebf > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMTQueries.java > 3d8eb83b04 > > itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloQTestUtil.java > 060e0cd3e2 > > itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloTestSetup.java > 47cf7ac79a > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java > 64f29194d5 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java > 0d64cfa1ac > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreCliDriver.java > bdb15b3869 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreNegativeCliDriver.java > 801c44b40c > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java > 841344438e > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java > 8ce43495e6 > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java > 4d40ef9047 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java > 252e9f6b90 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java > c009cec57b > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java > 0807da1c7c > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java > badb4a5888 > itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java > 6a6b1003b6 > itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java > cc63a6cc83 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestArguments.java > 18269ebc92 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 0e8b82930e > > itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java > 77de3faa1f > > > Diff: https://reviews.apache.org/r/68895/diff/2/ > > > Testing > --- > > > Thanks, > > denys kuzmenko > >
Re: Review Request 68895: HadoopVer was ignored in QTestUtil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- (Updated Oct. 5, 2018, 10 a.m.) Review request for hive, Zoltan Haindrich and Peter Vary. Bugs: HIVE-20647 https://issues.apache.org/jira/browse/HIVE-20647 Repository: hive-git Description --- - Removed obsolete hadoopVer from QTestUtil - Cleaned up QTestUtil, QTestArgumentsBuilder - Refactored AccumuloTestSetup, AccumuloQTestUtil due to findbugs violation: (UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR: Uninitialized read of field method called from constructor of superclass) Diffs (updated) - itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java b7e563aebf itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMTQueries.java 3d8eb83b04 itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloQTestUtil.java 060e0cd3e2 itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloTestSetup.java 47cf7ac79a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java 64f29194d5 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java 0d64cfa1ac itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreCliDriver.java bdb15b3869 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreNegativeCliDriver.java 801c44b40c itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java 841344438e itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java 8ce43495e6 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java 4d40ef9047 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java 252e9f6b90 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java c009cec57b itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java 0807da1c7c itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java badb4a5888 itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java 6a6b1003b6 itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java cc63a6cc83 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestArguments.java 18269ebc92 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 0e8b82930e itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java 77de3faa1f Diff: https://reviews.apache.org/r/68895/diff/2/ Changes: https://reviews.apache.org/r/68895/diff/1-2/ Testing --- Thanks, denys kuzmenko
Review Request 68895: HadoopVer was ignored in QTestUtil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- Review request for hive, Zoltan Haindrich and Peter Vary. Bugs: HIVE-20647 https://issues.apache.org/jira/browse/HIVE-20647 Repository: hive-git Description --- - Removed obsolete hadoopVer from QTestUtil - Cleaned up QTestUtil, QTestArgumentsBuilder - Refactored AccumuloTestSetup, AccumuloQTestUtil due to findbugs violation: (UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR: Uninitialized read of field method called from constructor of superclass) Diffs - itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java b7e563aebf itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMTQueries.java 3d8eb83b04 itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloQTestUtil.java 060e0cd3e2 itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloTestSetup.java 47cf7ac79a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java 64f29194d5 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java 0d64cfa1ac itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreCliDriver.java bdb15b3869 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreNegativeCliDriver.java 801c44b40c itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java 841344438e itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java 8ce43495e6 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java 4d40ef9047 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java 252e9f6b90 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java c009cec57b itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java 0807da1c7c itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java badb4a5888 itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java 6a6b1003b6 itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java cc63a6cc83 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestArguments.java 18269ebc92 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 0e8b82930e itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java 77de3faa1f Diff: https://reviews.apache.org/r/68895/diff/1/ Testing --- Thanks, denys kuzmenko
