Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review210298 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Nov. 2,

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/ --- (Updated Nov. 2, 2018, 10:10 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Nov. 1, 2018, 10:37 p.m., Jesús Camacho Rodríguez wrote: > > common/src/java/org/apache/hadoop/hive/common/type/HiveChar.java > > Lines 37 (patched) > > > > > > Could we avoid adding this new constructor and let

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review210259 --- common/src/java/org/apache/hadoop/hive/common/type/HiveChar.java

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/ --- (Updated Oct. 30, 2018, 11:32 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 20, 2018, 6:57 p.m., Ashutosh Chauhan wrote: > > Overall latest version of the patch LGTM. It is a bit messy that all this logic lives here and probably we could rely on inspectors and existing logic to make everything cleaner. Let's get this one in, and we can tackle in follow-up.

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/ --- (Updated Oct. 23, 2018, 11:49 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 20, 2018, 8:57 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/join45.q.out > > Line 717 (original), 717 (patched) > > > > > > As discussed this should have been > > (struct(cast

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 21, 2018, 8:55 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > > Line 1171 (original), 1176 (patched) > > > > > > Can remove this TODO now. this

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 20, 2018, 6:57 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/in_typecheck_pointlook.q.out > > Lines 56 (patched) > > > > > > I expected 'Unknown' should have been char of length 6. Is

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 20, 2018, 8:57 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/in_typecheck_pointlook.q > > Lines 2 (patched) > > > > > > Any reason for this? not needed > On Oct. 20, 2018, 8:57

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review209831 ---

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review209827 --- ql/src/test/queries/clientpositive/in_typecheck_pointlook.q

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/ --- (Updated Oct. 20, 2018, 7:51 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 19, 2018, 1:50 a.m., Vineet Garg wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > > Line 1171 (original), 1177 (patched) > > > > > > wrong comparisions spelling thank

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 19, 2018, 9:54 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > > Line 1172 (original), 1181 (patched) > > > > > > This TODO will be good to

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 19, 2018, 7:54 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out > > Line 371 (original), 370 (patched) > > > > > > Unrelated to this patch, but I think subq

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review209778 ---

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/#review209764 ---

Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69019/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-20617