Re: Review Request 69107: HIVE-20512

2018-11-08 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Nov. 8, 2018, 5:16 p.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-11-07 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Nov. 7, 2018, 8:52 p.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-11-05 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Nov. 6, 2018, 5:08 a.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-11-05 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review210338 ---

Re: Review Request 69107: HIVE-20512

2018-10-31 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Oct. 31, 2018, 5:29 p.m., Antal Sinkovits wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Line 62 (original), 83 (patched) > > > > > > Probably these three rows can move

Re: Review Request 69107: HIVE-20512

2018-10-31 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Oct. 31, 2018, 11:15 p.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-10-31 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review210230 ---

Re: Review Request 69107: HIVE-20512

2018-10-26 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Oct. 26, 2018, 5:13 p.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-10-25 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review210041 ---

Re: Review Request 69107: HIVE-20512

2018-10-25 Thread Sahil Takiar
> On Oct. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Line 49 (original), 52 (patched) > > > > > > i think volatile long is sufficient

Re: Review Request 69107: HIVE-20512

2018-10-25 Thread Sahil Takiar
> On Oct. 24, 2018, 8:58 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Line 67 (original), 67 (patched) > > > > > > Creating this as

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209986 ---

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Oct. 24, 2018, 8:51 a.m., Antal Sinkovits wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Lines 56 (patched) > > > > > > Any reason why we use Timer? > > > > From

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- (Updated Oct. 24, 2018, 8:55 p.m.) Review request for hive, Antal Sinkovits,

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Oct. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Line 50 (original), 53 (patched) > > > > > > this need to be volatile since it is

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Bharathkrishna Guruvayoor Murali via Review Board
> On Oct. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java > > Line 49 (original), 52 (patched) > > > > > > i think volatile long is sufficient

Re: Review Request 69107: HIVE-20512

2018-10-24 Thread Antal Sinkovits via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209950 ---

Re: Review Request 69107: HIVE-20512

2018-10-23 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/#review209935 ---

Review Request 69107: HIVE-20512

2018-10-20 Thread Bharathkrishna Guruvayoor Murali via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ --- Review request for hive, Antal Sinkovits, Sahil Takiar, and Vihang Karajgaonkar.