Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-02-01 Thread Vaibhav Gumashta
> On Jan. 29, 2019, 2:04 a.m., Eugene Koifman wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java > > Lines 299 (patched) > > > > > >

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-28 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review212399 ---

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 28, 2019, 7:49 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-25 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 26, 2019, 12:32 a.m.) Review request for hive and Eugene

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-25 Thread Vaibhav Gumashta
> On Jan. 23, 2019, 1:23 a.m., Eugene Koifman wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java > > Lines 196 (patched) > > > > > > I don't understand the

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-22 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review212198 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-21 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 22, 2019, 7:04 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-18 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 18, 2019, 10:41 p.m.) Review request for hive and Eugene

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-18 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 18, 2019, 9:40 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-10 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 10, 2019, 7:23 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-08 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Jan. 8, 2019, 7:18 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-20 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review210740 ---

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-19 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- (Updated Nov. 19, 2018, 11:49 a.m.) Review request for hive and Eugene

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-18 Thread Vaibhav Gumashta
> On Nov. 16, 2018, 3:02 a.m., Eugene Koifman wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2685 (patched) > > > > > > "And minor compaction will be disabled." - should make sure

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-18 Thread Vaibhav Gumashta
> On Nov. 16, 2018, 3:02 a.m., Eugene Koifman wrote: > > Addressed the comments; will upload changes in the patch. > On Nov. 16, 2018, 3:02 a.m., Eugene Koifman wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2685 (patched) > >

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-15 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review210589 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-15 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/ --- Review request for hive and Eugene Koifman. Bugs: HIVE-20699