Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211278 --- Ship it! Ship It! - Adam Szita On Dec. 12, 2018, 3:13 p.m., Antal Sinkovits wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69560/ > --- > > (Updated Dec. 12, 2018, 3:13 p.m.) > > > Review request for hive, Denys Kuzmenko, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > --- > > It can happen, that when in one given session, multiple queries are executed, > that due to a race condition, multiple spark application master gets kicked > off. > In this case, the one that started earlier, will not be killed, when the hive > session closes, consuming resources. > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java > d384ed6db6f4630ee2ef309854236e8f12926688 > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSparkUtilities.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69560/diff/1/ > > > Testing > --- > > > Thanks, > > Antal Sinkovits > >
Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211237 --- Ship it! Ship It! - Denys Kuzmenko On Dec. 12, 2018, 3:13 p.m., Antal Sinkovits wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69560/ > --- > > (Updated Dec. 12, 2018, 3:13 p.m.) > > > Review request for hive, Denys Kuzmenko, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > --- > > It can happen, that when in one given session, multiple queries are executed, > that due to a race condition, multiple spark application master gets kicked > off. > In this case, the one that started earlier, will not be killed, when the hive > session closes, consuming resources. > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java > d384ed6db6f4630ee2ef309854236e8f12926688 > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSparkUtilities.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69560/diff/1/ > > > Testing > --- > > > Thanks, > > Antal Sinkovits > >
Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/ --- Review request for hive, Denys Kuzmenko, Peter Vary, and Adam Szita. Repository: hive-git Description --- It can happen, that when in one given session, multiple queries are executed, that due to a race condition, multiple spark application master gets kicked off. In this case, the one that started earlier, will not be killed, when the hive session closes, consuming resources. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java d384ed6db6f4630ee2ef309854236e8f12926688 ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSparkUtilities.java PRE-CREATION Diff: https://reviews.apache.org/r/69560/diff/1/ Testing --- Thanks, Antal Sinkovits
