Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-02-07 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review212622 --- Ship it! Ship It! - Peter Vary On febr. 6, 2019, 9:17 du, Da

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-02-06 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/ --- (Updated Feb. 6, 2019, 9:17 p.m.) Review request for hive. Repository: hive-g

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-02-06 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/ --- (Updated Feb. 6, 2019, 8:34 p.m.) Review request for hive. Repository: hive-g

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-02-06 Thread David Mollitor
> On Jan. 8, 2019, 10:04 a.m., Peter Vary wrote: > > Thanks for the patch! > > Two nits below. > > Also a bit concerned about the size calculation - seems ok, but it would be > > good to have a few test case which validates the contentsummary > > calculations (when every path is cached/only few

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-18 Thread Peter Vary via Review Board
> On jan. 8, 2019, 10:04 de, Peter Vary wrote: > > Thanks for the patch! > > Two nits below. > > Also a bit concerned about the size calculation - seems ok, but it would be > > good to have a few test case which validates the contentsummary > > calculations (when every path is cached/only few p

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-14 Thread David Mollitor
> On Jan. 8, 2019, 10:04 a.m., Peter Vary wrote: > > Thanks for the patch! > > Two nits below. > > Also a bit concerned about the size calculation - seems ok, but it would be > > good to have a few test case which validates the contentsummary > > calculations (when every path is cached/only few

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-14 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/ --- (Updated Jan. 14, 2019, 3:36 p.m.) Review request for hive. Changes ---

Re: Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-08 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review211758 --- Thanks for the patch! Two nits below. Also a bit concerned about t

Review Request 69683: [HIVE-21071] Improve getInputSummary

2019-01-07 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/ --- Review request for hive. Repository: hive-git Description --- Improve pe