Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

2019-11-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/#review218491 --- LGTM, just minor comments. Also you mentioned unit test, do not se

Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

2019-11-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/#review218490 --- ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java L

Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

2019-11-04 Thread Aron Hamvas via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/ --- (Updated Nov. 4, 2019, 10:02 a.m.) Review request for hive, Denys Kuzmenko, Mar

Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

2019-10-30 Thread Aron Hamvas via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/ --- Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and Peter