Re: Review Request 72151: HIVE-22376: Cancelled query still prints exception if it was stuck in waiting for lock

[Denys Kuzmenko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72151/#review219612
---




ql/src/java/org/apache/hadoop/hive/ql/Driver.java
Lines 400 (patched)


Could you please elaborate on terminal state. Maybe I am lacking the 
context (is it only when query is cancelled), but it's not obvious for me what 
might lead us to this state.


- Denys Kuzmenko


On Feb. 19, 2020, 9:21 a.m., Aron Hamvas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72151/
> ---
> 
> (Updated Feb. 19, 2020, 9:21 a.m.)
> 
> 
> Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and 
> Peter Vary.
> 
> 
> Bugs: HIVE-22376
> https://issues.apache.org/jira/browse/HIVE-22376
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> If the reason for lock acquisition failure is that the query is canceled, the 
> exception should be ignored.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
> 48ebc4f87071bae4cc39309ada8d90dfc5c64f5b 
> 
> 
> Diff: https://reviews.apache.org/r/72151/diff/2/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> HIVE-22376.patch
>   
> https://reviews.apache.org/media/uploaded/files/2020/02/19/41c20e4c-57f6-46cc-988c-3b76041aa7ee__HIVE-22376.patch
> 
> 
> Thanks,
> 
> Aron Hamvas
> 
>

Re: Review Request 72151: HIVE-22376: Cancelled query still prints exception if it was stuck in waiting for lock

[Aron Hamvas via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72151/
---

(Updated Feb. 19, 2020, 9:21 a.m.)


Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and 
Peter Vary.


Bugs: HIVE-22376
https://issues.apache.org/jira/browse/HIVE-22376


Repository: hive-git


Description
---

If the reason for lock acquisition failure is that the query is canceled, the 
exception should be ignored.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
48ebc4f87071bae4cc39309ada8d90dfc5c64f5b 


Diff: https://reviews.apache.org/r/72151/diff/2/

Changes: https://reviews.apache.org/r/72151/diff/1-2/


Testing
---


File Attachments (updated)


HIVE-22376.patch
  
https://reviews.apache.org/media/uploaded/files/2020/02/19/41c20e4c-57f6-46cc-988c-3b76041aa7ee__HIVE-22376.patch


Thanks,

Aron Hamvas

Review Request 72151: HIVE-22376: Cancelled query still prints exception if it was stuck in waiting for lock

[Aron Hamvas via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72151/
---

Review request for hive, Denys Kuzmenko, Marta Kuczora, Laszlo Pinter, and 
Peter Vary.


Bugs: HIVE-22376
https://issues.apache.org/jira/browse/HIVE-22376


Repository: hive-git


Description
---

If the reason for lock acquisition failure is that the query is canceled, the 
exception should be ignored.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
48ebc4f87071bae4cc39309ada8d90dfc5c64f5b 


Diff: https://reviews.apache.org/r/72151/diff/1/


Testing
---


Thanks,

Aron Hamvas