Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-31 Thread Marton Bod
> On March 31, 2020, 9:35 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 199 (patched) > > > > > > %d could be

Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-31 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220146 --- Thanks for the patch Marci! A few questions below, feel free to

Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-31 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220139 --- LGTM, 1 small comment, for your consideration, otherwise - ship

Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-26 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220087 --- LGTM, however there are some issues to consider.

Re: Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-26 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220086 ---

Review Request 72264: HIVE-23052: Optimize lock enqueueing in TxnHandler

2020-03-24 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git