Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > Minor comments only. > > Thanks for the patch! Thanks for the review!! > On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > >

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220822 --- Ship it! Ship It! - Peter Vary On máj. 19, 2020, 5:58 de, Ka

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On máj. 18, 2020, 12:51 du, Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > > > > > > Migth want to add asserts here to check non-null argument >

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ --- (Updated May 19, 2020, 5:58 a.m.) Review request for hive, Laszlo Pinter and Pe

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

> On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > > > > > > Migth want to add asserts here to check non-null argument

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220805 --- Minor comments only. Thanks for the patch! common/src/java/org/a

Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ --- Review request for hive and Laszlo Pinter. Bugs: HIVE-22971 https://issues.