Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-09 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220265 --- Ship it! Ship It! - Denys Kuzmenko On April 8, 2020, 3:09

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-08 Thread Marton Bod
> On April 8, 2020, 3:23 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java > > Line 60 (original), 60 (patched) > > > > > >

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-08 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220258 --- LGTM, just few more comments

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-08 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/ --- (Updated April 8, 2020, 3:09 p.m.) Review request for hive, Denys Kuzmenko,

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-08 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220256 --- metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql Line

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-07 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220239 --- LGTM, some comments

Review Request 72324: HIVE-22750: Consolidate LockType naming

2020-04-06 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/ --- Review request for hive, Denys Kuzmenko, Peter Vary, and Zoltan Chovan.