Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 28, 2020, 3:38 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 27, 2020, 3:04 p.m., Peter Vary wrote: > > Fix it and ship it Thank you for the reviews, fixed the issues and got a green run. > On April 27, 2020, 3:04 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > > Lines

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220500 --- Fix it, then Ship it! Fix it and ship it

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 24, 2020, 3:14 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1453 (patched) > > > > > > Why is this

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 24, 2020, 2:16 p.m., Denys Kuzmenko wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > > Lines 1068 (patched) > > > > > > Is it important? I thought TXNS table is cleaned

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 24, 2020, 3:40 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220487 --- Overall looks good. There are some changes which might not be

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220483 ---

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 23, 2020, 2:48 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 699 (patched) > > > > > > openTxns(dbConn,

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 12:51 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 172 (original), 225 (patched) > > > > > >

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 7:53 a.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > This is a really big/scary change. I am really interested in the > > performance results! :) > > Thanks for all the effort! Some questions below Thank you for the review, i fixed most of them, but have a few questions. > On April 20,

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > LGTM, just a few comments Thank you for the review, I fixed most of the issues, but have a few question. > On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > >

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 780 (patched) > > > > > > TXN_META_INFO? What

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220369 --- This is a really big/scary change. I am really interested in the

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220367 --- LGTM, just a few comments

Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- Review request for hive and Peter Vary. Repository: hive-git Description