Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Rajesh Balamohan
> On May 13, 2020, 3:03 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > > Lines 197 (patched) > > > > > > Aah I see, Make sense. > > Can y

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/#review220734 --- llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Task

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Rajesh Balamohan
> On May 13, 2020, 2:45 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > > Lines 197 (patched) > > > > > > Still didn't follow. What is conf.get

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/#review220732 --- llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Task

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/ --- (Updated May 13, 2020, 2:28 a.m.) Review request for hive and Ashutosh Chauhan.

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Rajesh Balamohan
> On May 13, 2020, 12:40 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > > Line 257 (original), 259 (patched) > > > > > > I am not sure how mem

Re: Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/#review220729 --- llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Task

Review Request 72503: HIVE-23449: LLAP: Reduce mkdir and config creations in submitWork hotpath

2020-05-12 Thread Rajesh Balamohan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Descriptio