Re: Turn around on patches that do not need full unit testing

2012-06-15 Thread Alan Gates
One approach I've seen other projects take is to have an "ant test-commit" target that users are responsible to run before committing. This is a short (15 min or less) target that runs all true unit tests (tests that exercise just a class or two in isolation) and a couple of functional tests th

Re: Turn around on patches that do not need full unit testing

2012-06-11 Thread Edward Capriolo
I agree. Having a short-test and long-test might make more sense. IE long-test includes funky serdes and UDFs. As for "In the meanwhile, check in without test may introduce bug which can break production cluster.costly." the solution is not to run trunk. Run only releases. All the tests are run b

Re: Turn around on patches that do not need full unit testing

2012-06-10 Thread Gang Liu
Yeah it is frustrated to take a long time to turn around for a tiny change. It is understood. In the meanwhile, check in without test may introduce bug which can break production cluster.costly. I think the problem is not if we should run test but running tests takes long time. If it takes rea

Turn around on patches that do not need full unit testing

2012-06-10 Thread Edward Capriolo
Hive's unit tests take a long time. There are many simple patches we can get into hive earlier if we drop the notion of running the full test suite to QA every patch. For example: https://issues.apache.org/jira/browse/HIVE-3081 --> spelling mistakes that involved types https://issues.apache.org/