Good call, I made a very basic fix and noted on the Phabricator page that
it's no longer used.
Brock
On Thu, Jan 23, 2014 at 3:32 PM, Lefty Leverenz leftylever...@gmail.comwrote:
The wiki still has Phabricator information, with nothing about Apache's
review board.
How to Contribute:
The wiki still has Phabricator information, with nothing about Apache's
review board.
How to Contribute: Review
Processhttps://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ReviewProcess
See
+1 (non-binding)
Its good to use a common review tool and one that's has no third party
dependency.
thanks
Prasad
On Fri, Oct 18, 2013 at 1:59 PM, Ashutosh Chauhan hashut...@apache.orgwrote:
0
IMO phabricator interface is better than review board, but threat of losing
comments and
0
IMO phabricator interface is better than review board, but threat of losing
comments and patches is also real.
Actually, we already lost in few cases, ironically it was RB. Try to read
the very first review request posted on HIVE-1634
Ashutosh
On Thu, Oct 17, 2013 at 6:55 PM, Yin Huai
Major +1 (non-binding). Using 3rd party tools where we have no option for
support or help is not good.
Alan.
On Oct 16, 2013, at 5:32 PM, Edward Capriolo wrote:
Our wiki has instructions for posting to phabricator for code reviews.
+1 (non-binding)
On Thu, Oct 17, 2013 at 1:08 PM, Alan Gates ga...@hortonworks.com wrote:
Major +1 (non-binding). Using 3rd party tools where we have no option for
support or help is not good.
Alan.
On Oct 16, 2013, at 5:32 PM, Edward Capriolo wrote:
Our wiki has instructions for
+1
But I have found that apache reviewboard is sometimes flaky. I assume
that we can still use phabricator in one-off cases, if there is an
extended downtime for reviewboard.
On Thu, Oct 17, 2013 at 1:08 PM, Alan Gates ga...@hortonworks.com wrote:
Major +1 (non-binding). Using 3rd party tools
I would rather us not use phabricator at all. One of the largest reasons is
a fear that if phabricator is shut down we will lose the comments on it. We
can count on the ASF to maintain and backup review board. If it flaky we
can file some tickets with infra or bring this fact up in a board meeting
Ed,
I didn't remember being unable to see revisions without a login. That is
uncool. I'll change my vote to +1.
-- Owen
On Wed, Oct 16, 2013 at 9:08 PM, Edward Capriolo edlinuxg...@gmail.comwrote:
Owen,
In your issues:
https://issues.apache.org/jira/browse/HIVE-5567
When I click this
+1
Thanks,
Gunther.
On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley omal...@apache.org wrote:
Ed,
I didn't remember being unable to see revisions without a login. That is
uncool. I'll change my vote to +1.
-- Owen
On Wed, Oct 16, 2013 at 9:08 PM, Edward Capriolo edlinuxg...@gmail.com
+1
On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner
ghagleit...@hortonworks.com wrote:
+1
Thanks,
Gunther.
On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley omal...@apache.org wrote:
Ed,
I didn't remember being unable to see revisions without a login. That
is
uncool. I'll
Our wiki has instructions for posting to phabricator for code reviews.
https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
Phabricator now requires an external facebook account to review patches,
and we have no technical support contact where phabricator is hosted. It
also
+1 to remove the phabricator instructions from the wiki.
On Wed, Oct 16, 2013 at 7:32 PM, Edward Capriolo edlinuxg...@gmail.com wrote:
Our wiki has instructions for posting to phabricator for code reviews.
https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
Phabricator now
+1
On Wed, Oct 16, 2013 at 6:31 PM, Brock Noland br...@cloudera.com wrote:
+1 to remove the phabricator instructions from the wiki.
On Wed, Oct 16, 2013 at 7:32 PM, Edward Capriolo edlinuxg...@gmail.com
wrote:
Our wiki has instructions for posting to phabricator for code reviews.
+1 (non-binding)
On Wed, Oct 16, 2013 at 6:45 PM, Carl Steinbach cwsteinb...@gmail.comwrote:
+1
On Wed, Oct 16, 2013 at 6:31 PM, Brock Noland br...@cloudera.com wrote:
+1 to remove the phabricator instructions from the wiki.
On Wed, Oct 16, 2013 at 7:32 PM, Edward Capriolo
Owen,
In your issues:
https://issues.apache.org/jira/browse/HIVE-5567
When I click this link:
REVISION DETAIL
https://reviews.facebook.net/D13479
I am prompted for a password.
On Wed, Oct 16, 2013 at 11:16 PM, Owen O'Malley owen.omal...@gmail.comwrote:
-0
I like phabricator, but it is a
16 matches
Mail list logo
