[jira] [Commented] (HIVEMALL-22) Review and merge pending Pull Requests before entering Incubator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVEMALL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714309#comment-15714309
 ] 

ASF GitHub Bot commented on HIVEMALL-22:


Github user myui closed the pull request at:

https://github.com/apache/incubator-hivemall/pull/1


> Review and merge pending Pull Requests before entering Incubator
> 
>
> Key: HIVEMALL-22
> URL: https://issues.apache.org/jira/browse/HIVEMALL-22
> Project: Hivemall
>  Issue Type: New Feature
>Reporter: Makoto Yui
>Assignee: Makoto Yui
>
> Need to review and merge pending Pull Requests in
> https://github.com/myui/hivemall/pulls
> * Feature Selection
> https://github.com/myui/hivemall/pull/385
> * SST change point detection
> https://github.com/myui/hivemall/pull/356
> * Checkstyle
> https://github.com/myui/hivemall/pull/343
> * System Test
> https://github.com/myui/hivemall/pull/336
> * Kernelized Passive Aggressive
> https://github.com/myui/hivemall/pull/304
> * Separate Optimizer
> https://github.com/myui/hivemall/pull/285



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVEMALL-22) Review and merge pending Pull Requests before entering Incubator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVEMALL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714306#comment-15714306
 ] 

ASF GitHub Bot commented on HIVEMALL-22:


GitHub user myui opened a pull request:

https://github.com/apache/incubator-hivemall/pull/1

[WIP] Separate optimizer implementations

This PR is based on [a pending 
PR](https://github.com/myui/hivemall/pull/285) by @maropu that is sent before 
Hivemall entered Apache Incubator.

See [JIRA](https://issues.apache.org/jira/browse/HIVEMALL-22
) for tracking the status of this issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myui/incubator-hivemall JIRA-22/pr-285

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hivemall/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 4cb84773f4c88f757d70b480a80068d597e756a7
Author: myui 
Date:   2016-06-16T22:59:11Z

Changed the behavior of binarize_label

commit adb23e3c537d9c2d2ce36c27700a85ff6852964b
Author: Sotaro Sugimoto 
Date:   2016-04-12T06:23:12Z

Added Kernelized Passive-Aggressive Algorithm for Classification Problems.

commit bc228746c7f7b1abc0f6e7846d52ca1edad7fea7
Author: Sotaro Sugimoto 
Date:   2016-04-12T09:14:45Z

Bug fixes
Also newly added KernelizedPassiveAggressiveUDTFTest based on 
PassiveAggressiveUDTFTest, but tests are not done for newly added functionality.

commit adac4e5bd0d89cc8c68768c9fb5bc1765bc3fac3
Author: Sotaro Sugimoto 
Date:   2016-04-14T09:51:14Z

Test for news20 written; some bugs fixed.
Bug still occurs for news20-small.binary where the loss does not match 
between udtf and udtfPKI starting at sample 51, where the label switches from 
all -1s to all +1s. Also, news20.binary not included due to large filesize.

commit 6072a2ae7f1d0f8a0023dbe428a38c201386e38e
Author: myui 
Date:   2016-04-14T11:51:57Z

Refactored to use Bitset for support vector indices

commit ecf4f3ab55ccdbe7c57bcd21b292e485465fb566
Author: myui 
Date:   2016-04-14T11:55:49Z

Changed resource location of unit tests

commit 3994cc7bb706e0b073278176eee6a1a5b78bebf6
Author: Sotaro Sugimoto 
Date:   2016-04-15T06:17:18Z

Both normal and PKI versions of KPA now learn identically.
Note that testTime was added to see how much faster PKI is, but it appears 
that PKI is actually slower than normal KPA for non-sparse support vectors, 
since PKI must go through the work of finding all matching support vectors, 
which is O(number of support vectors) for a completely full match.

commit 31d981bd0082d4d5c40d7eb536f47f70455a3c52
Author: Sotaro Sugimoto 
Date:   2016-04-15T09:38:49Z

Fixed incorrect alpha calculation/storage.
Also fixed tests and asserts to match correct alpha calculations.

commit e2812fd035f51877167f0c77aff397fa45be0bef
Author: Sotaro Sugimoto 
Date:   2016-04-15T09:59:16Z

Added FloatArrayList.
Also changed alpha from DoubleArrayList to FloatArrayList.

commit c793d47e0de18d32a56d2d1fd1744470f7283613
Author: Sotaro Sugimoto 
Date:   2016-04-20T03:14:12Z

Added kernel expansion option (untested)

commit 4716b34ad5038761d18e422833d9334140dd0908
Author: Sotaro Sugimoto 
Date:   2016-04-21T03:34:26Z

Tests for KPA added.
Note that kernel splitting (in KernelExpansionKPA) is incomplete.

commit f986803901824ad831c7c8a2504c26797d765f23
Author: Sotaro Sugimoto 
Date:   2016-04-26T04:21:22Z

Kernel Expansion complete with tests.
Also removed Kernel Splitting (probably uses too much memory).

commit f81948c5c7b83155eb29369a59f1fc65bb607f91
Author: Takeshi YAMAMURO 
Date:   2016-05-02T14:43:42Z

Add optimizer implementations

commit 3620eb89993db22ce8aee924d3cc0df33a5f9618
Author: Takeshi YAMAMURO 
Date:   2016-09-20T16:52:22Z

Revert some modifications

commit 775ae4f79466265e703ec1f3a03cf6ce77459087
Author: myui 
Date:   2016-12-02T06:33:32Z

Merge branch 'feature/kernelized_pa' of https://github.com/L3Sota/hivemall 
into JIRA-22/pr-304

commit 05766432c45f89627e423245e5aec3ced6d0c100
Author: myui 
Date:   2016-12-02T06:35:05Z

Merge branch 'AddOptimizers' of https://github.com/maropu/hivemall into 
JIRA-22/pr-285




> Review and merge pending Pull Requests before entering Incubator
> 
>
> Key: HIVEMALL-22
> 

Re: Roadmap for the initial Apache release (v0.5-rc.1)

[Makoto Yui]

Kai,

I ran the following command.

Now we can merge pending pull requests from JIRA-22/pr-xxx branches :-)

Makoto



git clone https://github.com/myui/hivemall.git incubator-hivemall

git checkout -b tmp 5114d8f289025350b85f30472f4eb122817cae82
git branch -d master
git checkout -b master
git branch -d tmp

git checkout -b JIRA-22/pr-385 origin/feature_selection

git checkout master
git checkout -b JIRA-22/pr-356
git pull https://github.com/takuti/hivemall.git sst-changepoint

git checkout master
git checkout -b JIRA-22/pr-336
git pull https://github.com/amaya382/hivemall.git feature/systemtest

git checkout master
git checkout -b JIRA-22/pr-304
git pull https://github.com/L3Sota/hivemall.git feature/kernelized_pa

git checkout -b JIRA-22/pr-285
git pull https://github.com/maropu/hivemall.git AddOptimizers
>> resolve conflict
git add spark/spark-2.0/src/test/scala/hivemall/mix/server/MixServerSuite.scala
git commit
git checkout master

-

git filter-branch --index-filter 'git rm -r --cached --ignore-unmatch
lib/ target/*.jar' --tag-name-filter cat --prune-empty -- --all
rm -rf .git/refs/original/
git reflog expire --expire=now --all
git gc --aggressive --prune=now

-

git remote rm origin
git remote add origin
https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git

git config user.email m...@apache.org

git push origin :v0.4.2-rc.2
git push origin :v0.5-alpha.1

-

git push -f -u origin master
git push origin v0.4.2-rc.2
git push origin v0.5-alpha.1
git push --all origin

-

git clone https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git
cd incubator-hivemall

git_find_big.sh | head -10

All sizes are in kB's. The pack column is the size of the object,
compressed, inside the pack file.
size  pack  SHA   location
3982  702   8233e5c127a481615c2c9f3f67092d36996b1f21
core/src/test/resources/hivemall/classifier/news20-medium.binary
1391  1383  b8d432e6a3c0074951abd35caf0a777caf47afbf
xgboost/lib/xgboost4j_0.60-0.10.jar
765   303   11c617713ee2ad3f847aee7627ee8639c5a79667
core/src/test/resources/hivemall/mf/ml1k.train
639   613   de4e32983604238bc72fe3f6cb6beea76fde0e8d
src/site/resources/images/hivemall_overview_bg.png
382   117   8b66187fe067c3aa389ce8c98108f349ceae159c
src/site/resources/fonts/fontawesome-webfont.svg
220   192   04d8605fd8daaafa72a2b6dfa2a2d48c75c57a10
src/site/resources/images/asf_bg.png
194   186   fb29a3d2ee04b7981463de89a77ccc7436f4ad9a
docs/gitbook/resources/images/techstack.png
191   76e00b1127f6fb4fdcc1606a20b05e16b5456acacc
core/src/test/resources/hivemall/mf/ml1k.test

2016-12-02 14:26 GMT+09:00 Makoto Yui :
> Kai,
>
> I got a good idea.
>
> Rewriting history of those pull requests and import those branches to
> ASF repository.
>
> Makoto
>
>
>
> 2016-12-02 9:48 GMT+09:00 Kai Sasaki :
>> Hi
>>
>> Sounds good. I’ll ask some contributors to submit PR against 
>> apache/incubator-hivemall.
>> Or can we do by ourselves? If so review should be done with current PRs.
>>
>> I think these 4 PRs can be ready to be merged before v0.5-rc1. We can mainly 
>> review these PRs.
>>
>> - Feature selection
>> - SST-based change finder
>> - checkstyle
>> - System test
>>
>> Kai
>>
>>
>>> On 2016 Dec 1, at 19:05, Makoto Yui  wrote:
>>>
>>> Hi,
>>>
>>> I created an umbrella ticket for creating the first Apache release of
>>> Hivemall (v0.5-rc.1).
>>> https://issues.apache.org/jira/browse/HIVEMALL-21
>>>
>>> Issues to be resolved in v0.5-rc.1 should be linked to the ticket.
>>>
>>> I would like to release the first apache release in Q1, 2017, possibly in 
>>> Feb.
>>>
>>> We need to review/fix/merge the pending PRs.
>>> https://github.com/myui/hivemall/pulls
>>>
>>> Also, we need to be managed them on ASF JIRA.
>>> We can invite some of contributors to Hivemall committers :-)
>>>
>>> Thanks,
>>> Makoto
>>

Re: Roadmap for the initial Apache release (v0.5-rc.1)

[Makoto Yui]

Kai,

I got a good idea.

Rewriting history of those pull requests and import those branches to
ASF repository.

Makoto



2016-12-02 9:48 GMT+09:00 Kai Sasaki :
> Hi
>
> Sounds good. I’ll ask some contributors to submit PR against 
> apache/incubator-hivemall.
> Or can we do by ourselves? If so review should be done with current PRs.
>
> I think these 4 PRs can be ready to be merged before v0.5-rc1. We can mainly 
> review these PRs.
>
> - Feature selection
> - SST-based change finder
> - checkstyle
> - System test
>
> Kai
>
>
>> On 2016 Dec 1, at 19:05, Makoto Yui  wrote:
>>
>> Hi,
>>
>> I created an umbrella ticket for creating the first Apache release of
>> Hivemall (v0.5-rc.1).
>> https://issues.apache.org/jira/browse/HIVEMALL-21
>>
>> Issues to be resolved in v0.5-rc.1 should be linked to the ticket.
>>
>> I would like to release the first apache release in Q1, 2017, possibly in 
>> Feb.
>>
>> We need to review/fix/merge the pending PRs.
>> https://github.com/myui/hivemall/pulls
>>
>> Also, we need to be managed them on ASF JIRA.
>> We can invite some of contributors to Hivemall committers :-)
>>
>> Thanks,
>> Makoto
>

[jira] [Updated] (HIVEMALL-22) Review and merge pending Pull Requests before entering Incubator

[Makoto Yui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVEMALL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Makoto Yui updated HIVEMALL-22:
---
Issue Type: New Feature  (was: Sub-task)
Parent: (was: HIVEMALL-21)

> Review and merge pending Pull Requests before entering Incubator
> 
>
> Key: HIVEMALL-22
> URL: https://issues.apache.org/jira/browse/HIVEMALL-22
> Project: Hivemall
>  Issue Type: New Feature
>Reporter: Makoto Yui
>Assignee: Makoto Yui
>
> Need to review and merge pending Pull Requests in
> https://github.com/myui/hivemall/pulls
> * Feature Selection
> https://github.com/myui/hivemall/pull/385
> * SST change point detection
> https://github.com/myui/hivemall/pull/356
> * Checkstyle
> https://github.com/myui/hivemall/pull/343
> * System Test
> https://github.com/myui/hivemall/pull/336
> * Kernelized Passive Aggressive
> https://github.com/myui/hivemall/pull/304
> * Separate Optimizer
> https://github.com/myui/hivemall/pull/285



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVEMALL-22) Review and merge pending Pull Requests before entering Incubator

[Makoto Yui (JIRA)]

Makoto Yui created HIVEMALL-22:
--

 Summary: Review and merge pending Pull Requests before entering 
Incubator
 Key: HIVEMALL-22
 URL: https://issues.apache.org/jira/browse/HIVEMALL-22
 Project: Hivemall
  Issue Type: Sub-task
Reporter: Makoto Yui
Assignee: Makoto Yui


Need to review and merge pending Pull Requests in
https://github.com/myui/hivemall/pulls

* Feature Selection
https://github.com/myui/hivemall/pull/385

* SST change point detection
https://github.com/myui/hivemall/pull/356

* Checkstyle
https://github.com/myui/hivemall/pull/343

* System Test
https://github.com/myui/hivemall/pull/336

* Kernelized Passive Aggressive
https://github.com/myui/hivemall/pull/304

* Separate Optimizer
https://github.com/myui/hivemall/pull/285



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Roadmap for the initial Apache release (v0.5-rc.1)

[Kai Sasaki]

Hi

Sounds good. I’ll ask some contributors to submit PR against 
apache/incubator-hivemall.
Or can we do by ourselves? If so review should be done with current PRs.

I think these 4 PRs can be ready to be merged before v0.5-rc1. We can mainly 
review these PRs.

- Feature selection
- SST-based change finder
- checkstyle
- System test

Kai


> On 2016 Dec 1, at 19:05, Makoto Yui  wrote:
> 
> Hi,
> 
> I created an umbrella ticket for creating the first Apache release of
> Hivemall (v0.5-rc.1).
> https://issues.apache.org/jira/browse/HIVEMALL-21
> 
> Issues to be resolved in v0.5-rc.1 should be linked to the ticket.
> 
> I would like to release the first apache release in Q1, 2017, possibly in Feb.
> 
> We need to review/fix/merge the pending PRs.
> https://github.com/myui/hivemall/pulls
> 
> Also, we need to be managed them on ASF JIRA.
> We can invite some of contributors to Hivemall committers :-)
> 
> Thanks,
> Makoto

Roadmap for the initial Apache release (v0.5-rc.1)

[Makoto Yui]

Hi,

I created an umbrella ticket for creating the first Apache release of
Hivemall (v0.5-rc.1).
https://issues.apache.org/jira/browse/HIVEMALL-21

Issues to be resolved in v0.5-rc.1 should be linked to the ticket.

I would like to release the first apache release in Q1, 2017, possibly in Feb.

We need to review/fix/merge the pending PRs.
https://github.com/myui/hivemall/pulls

Also, we need to be managed them on ASF JIRA.
We can invite some of contributors to Hivemall committers :-)

Thanks,
Makoto

[jira] [Closed] (HIVEMALL-14) Build instruction including xgboost library

[Makoto Yui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVEMALL-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Makoto Yui closed HIVEMALL-14.
--
Resolution: Fixed

> Build instruction including xgboost library
> ---
>
> Key: HIVEMALL-14
> URL: https://issues.apache.org/jira/browse/HIVEMALL-14
> Project: Hivemall
>  Issue Type: Improvement
>Reporter: Kai Sasaki
>Assignee: Kai Sasaki
>Priority: Minor
>
> We cannot simply build Hivemall without resolving xgboost dependencies.
> Though it will be resolved by 
> [#370|https://github.com/myui/hivemall/issues/370], it would be nice to show 
> current build instruction explicitly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (HIVEMALL-3) Move wiki documentation into GitBook

[Makoto Yui (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVEMALL-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Makoto Yui closed HIVEMALL-3.
-
Resolution: Done
  Assignee: Makoto Yui

Gitbook documentation has been implemented in 
https://github.com/apache/incubator-hivemall/tree/master/docs/gitbook

It's deployed on
https://github.com/apache/incubator-hivemall-site
http://hivemall.incubator.apache.org/userguide/index.html


> Move wiki documentation into GitBook
> 
>
> Key: HIVEMALL-3
> URL: https://issues.apache.org/jira/browse/HIVEMALL-3
> Project: Hivemall
>  Issue Type: Improvement
>Reporter: Kai Sasaki
>Assignee: Makoto Yui
>  Labels: documentation
>
> Current documentation is hosted GitHub wiki.
> It is better to move documentation to GitBook for searchability for users and 
> maintainability for developers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVEMALL-21) [Umbrella] Release Hivemall v0.5-rc.1

[Makoto Yui (JIRA)]

Makoto Yui created HIVEMALL-21:
--

 Summary: [Umbrella] Release Hivemall v0.5-rc.1
 Key: HIVEMALL-21
 URL: https://issues.apache.org/jira/browse/HIVEMALL-21
 Project: Hivemall
  Issue Type: Task
Reporter: Makoto Yui
Assignee: Makoto Yui


This is an umbrella ticket for creating the first Apache release of Hivemall 
(v0.5-rc.1).

Plan to release the first apache release in Q1, 2017.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Hivemall Podling Report (Dec 2016) - Mentor Signed-off required

[Makoto Yui]

The correct mentor signoff due is Dec 13 (Tue).

Thanks,
Makoto


2016-12-01 16:16 GMT+09:00 Makoto Yui :
> Dear our project Mentors (and committers),
>
> I updated the Hivemall podling report (Dec 2016) on
> https://wiki.apache.org/incubator/December2016
>
> Please review it and add a sign to it.
>
> The deadline is Dec 7 (Wed).
>
>> Daniel,
> You are now a mentor of our podling :-)
>
> Warm regards,
> Makoto