Re: svn commit: r160663 - httpd/httpd/trunk/modules/proxy/proxy_util.c

2005-04-09 Thread Mladen Turk
Sander Striker wrote: I'm not so sure this is goodness. The url passed into this function (ap_proxy_determine_connection) should be complete IIR the code correctly. Fixing up what is supposed to be the complete raised a flag for me. Yes, the balancer was missing the canon_handler. Mladen.

Re: svn commit: r160663 - httpd/httpd/trunk/modules/proxy/proxy_util.c

2005-04-09 Thread Jim Jagielski
On Apr 9, 2005, at 3:32 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Sat Apr 9 00:32:42 2005 New Revision: 160663 URL: http://svn.apache.org/viewcvs?view=revrev=160663 Log: Add r-args to uri-query if the original r-uri did not contain query string. This fixes #34266. Hold on a sec... This is

Re: svn commit: r160675 - httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2005-04-09 Thread Jim Jagielski
On Apr 9, 2005, at 6:12 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Sat Apr 9 03:12:01 2005 New Revision: 160675 URL: http://svn.apache.org/viewcvs?view=revrev=160675 Log: Add canon_handler for load balancer so that we have query string passed to remote. Beat me to it :) I should really

Re: svn commit: r160675 - httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2005-04-09 Thread Jim Jagielski
On Apr 9, 2005, at 6:12 AM, [EMAIL PROTECTED] wrote: + +if (strncasecmp(url, balancer:, 9) == 0) { +url += 9; +scheme = balancer; +} +else { +return DECLINED; +} + Hold on a sec... I need to test this, but by the time this is called, haven't we rewritten the

Re: svn commit: r160675 - httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2005-04-09 Thread Mladen Turk
Jim Jagielski wrote: +if (strncasecmp(url, balancer:, 9) == 0) { Hold on a sec... I need to test this, but by the time this is called, haven't we rewritten the URL (via rewrite_url()) to remove the 'balancer::' prefix? No. The canon_handler is called during fixup hook while rewrite_url

Re: svn commit: r160693 - httpd/httpd/trunk/modules/proxy/mod_proxy_ajp.c

2005-04-09 Thread William A. Rowe, Jr.
At 11:34 AM 4/9/2005, [EMAIL PROTECTED] wrote: Simplify canon_handler. There is no thing like ajps: protocol. Actually, there has to be (no?) ajp: is a specific protocol and should be designated. E.g. how to I forward proxy one set of requests to x.box.net via an ajp proxy, while forward

Re: svn commit: r160693 - httpd/httpd/trunk/modules/proxy/mod_proxy_ajp.c

2005-04-09 Thread Mladen Turk
William A. Rowe, Jr. wrote: At 11:34 AM 4/9/2005, [EMAIL PROTECTED] wrote: Simplify canon_handler. There is no thing like ajps: protocol. Actually, there has to be (no?) No. There is http,https,ftp,ajp,balancer. There is no thing like ajps, but I suppose this originates from copying the code from

Re: svn commit: r160645 - httpd/httpd/branches/2.0.x/STATUS

2005-04-09 Thread Sander Striker
[EMAIL PROTECTED] wrote: Author: wrowe Date: Fri Apr 8 17:38:46 2005 New Revision: 160645 @@ -208,7 +209,7 @@ * Win32: Move call to mpm_service_install to the rewrite_args hook from the post_config hook. http://svn.apache.org/viewcvs?view=revrev=154319 - +1: stoddard,

Re: svn commit: r160645 - httpd/httpd/branches/2.0.x/STATUS

2005-04-09 Thread Paul Querna
Sander Striker wrote: Paul, Justin, could you either provide me with a complete patch against 2.0.x or add the revisions I need to merge? I am backporting mod_version right now.

Re: svn commit: r160645 - httpd/httpd/branches/2.0.x/STATUS

2005-04-09 Thread Paul Querna
Paul Querna wrote: Sander Striker wrote: Paul, Justin, could you either provide me with a complete patch against 2.0.x or add the revisions I need to merge? I am backporting mod_version right now. Okay, I was backporting this, but ran into a few problems. First, it requires a minor MMN bump to