thaw() isn't a class method

2005-09-29 Thread Joe Schaefer
I didn't intend for APR::Request::Cookie::thaw() to be a class method, but somehow I documented it that way. Any objections to my applying this patch? Index: glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm === ---

Re: svn commit: r292397 - /httpd/httpd/branches/2.0.x/server/core.c

2005-09-29 Thread William A. Rowe, Jr.
Although it took two commits, please comment on the following patch to eliminate an 'unused variable' rv in some cases (happy to back out if there are objections); Index: server/core.c^M === --- server/core.c (revision 292396)

Re: svn commit: r292397 - /httpd/httpd/branches/2.0.x/server/core.c

2005-09-29 Thread Jeff Trawick
On 9/29/05, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Although it took two commits, please comment on the following patch to eliminate an 'unused variable' rv in some cases (happy to back out if there are objections); keep it

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Jim Jagielski
On Sep 28, 2005, at 5:09 PM, [EMAIL PROTECTED] wrote: Brian Akins wrote: Here is a trivial patch that will allow proxy_handler to run the request_status hook if pre_request fails. This is necessary if all balncer members are in an error state, so that other modules get a If all workers

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread r . pluem
Jim Jagielski wrote: On Sep 28, 2005, at 5:09 PM, [EMAIL PROTECTED] wrote: Brian Akins wrote: [..cut..] Hmmm... It might be best to, in ap_proxy_pre_request() set *balancer to NULL if the result from proxy_run_pre_request() isn't OK. Then we can call jump to cleanup. Yes, this

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Brian Akins
Mladen Turk wrote: if (access_status != OK) { if (access_status != HTTP_SERVICE_UNAVAILABLE) return access_status; else goto cleanup; } I guess that makes sense. I just want to chatch the following cases: No available workers - all in error or busy worker failed - ie

2.3.0 CHANGES

2005-09-29 Thread Colm MacCarthaigh
*) Teach mod_ssl to use arbitrary OIDs in an SSLRequire directive, allowing string-valued client certificate attributes to be used for access control, as in: SSLRequire value in OID(1.3.6.1.4.1.18060.1) [Martin Kraemer, David Reid] Should that be PeerExtList rather than OID, in the

Re: Time for 1.3.34?

2005-09-29 Thread Sander Temme
On Sep 28, 2005, at 12:14 PM, Jim Jagielski wrote: I'd like to propose a release of 1.3.34. I'll volunteer to be RM again. +1. Thanks. S. smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Jim Jagielski
On Sep 29, 2005, at 9:40 AM, Brian Akins wrote: Mladen Turk wrote: if (access_status != OK) { if (access_status != HTTP_SERVICE_UNAVAILABLE) return access_status; else goto cleanup; } I guess that makes sense. I just want to chatch the following cases: No available

Re: [PATCH] stop killing piped loggers

2005-09-29 Thread r . pluem
Any reason why the patch below is not commited yet? I stumbled across this problem today and reminded myself of this discussion, but was astonished to find out that it never had been commited. Regards Rüdiger Joe Orton wrote: As discussed previously; this patch stops killing piped loggers;

Re: thaw() isn't a class method

2005-09-29 Thread Philip M. Gollucci
Joe Schaefer wrote: I didn't intend for APR::Request::Cookie::thaw() to be a class method, but somehow I documented it that way. Any objections to my applying this patch? +1 -- END What doesn't kill us can only make us

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread r . pluem
Jim Jagielski wrote: On Sep 29, 2005, at 9:40 AM, Brian Akins wrote: Mladen Turk wrote: if (access_status != OK) { if (access_status != HTTP_SERVICE_UNAVAILABLE) return access_status; else goto cleanup; } I guess that makes sense. I just want to chatch the

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Brian Akins
Jim Jagielski wrote: This means if access_status is DECLINED, we would return. Would that work for you?? Yes. Just need to run request_status in case of error. -- Brian Akins Lead Systems Engineer CNN Internet Technologies

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Jim Jagielski
Except for the formatting +1 :) On Sep 29, 2005, at 12:01 PM, [EMAIL PROTECTED] wrote: What about the following patch? I think it should address all the things discussed. Regards Rüdiger Index: mod_proxy.c === ---

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread r . pluem
As I try to improve my Apache code style awareness. What is wrong with the formatting? Regards Rüdiger Jim Jagielski wrote: Except for the formatting +1 :) On Sep 29, 2005, at 12:01 PM, [EMAIL PROTECTED] wrote: What about the following patch? I think it should address all the things

Re: 2.3.0 CHANGES

2005-09-29 Thread David Reid
Colm MacCarthaigh wrote: *) Teach mod_ssl to use arbitrary OIDs in an SSLRequire directive, allowing string-valued client certificate attributes to be used for access control, as in: SSLRequire value in OID(1.3.6.1.4.1.18060.1) [Martin Kraemer, David Reid] Should that be PeerExtList

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Jim Jagielski
Sorry :) The single line if statements. The pref is if (foo) banana(); rather than if (foo) banana(); On Sep 29, 2005, at 2:32 PM, [EMAIL PROTECTED] wrote: As I try to improve my Apache code style awareness. What is wrong with the formatting? Regards Rüdiger Jim

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread Sander Striker
[EMAIL PROTECTED] wrote: As I try to improve my Apache code style awareness. What is wrong with the formatting? http://httpd.apache.org/dev/styleguide.html The basic objection to your patch would be that statements after your if's; put them on the next line. HTH, Sander Regards

Re: 2.3.0 CHANGES

2005-09-29 Thread Colm MacCarthaigh
On Thu, Sep 29, 2005 at 07:32:39PM +0100, David Reid wrote: Colm MacCarthaigh wrote: *) Teach mod_ssl to use arbitrary OIDs in an SSLRequire directive, allowing string-valued client certificate attributes to be used for access control, as in: SSLRequire value in OID(1.3.6.1.4.1.18060.1)

Re: [PATCH] mod_proxy run cleanup on balancer failure

2005-09-29 Thread r . pluem
Jim Jagielski wrote: Sorry :) Thanks. So I guess this should be fine: Index: mod_proxy.c === --- mod_proxy.c (Revision 280422) +++ mod_proxy.c (Arbeitskopie) @@ -679,8 +679,22 @@ char *url = uri; /* Try to

Re: What's up for mod_mbox ?

2005-09-29 Thread Ian Holsman
Maxime Petazzoni wrote: Hi, It's been one month that my SoC project is now over. I even received the money from Google. Thanks again to all of you for your help and support during the summer. For now, I would really like to see something moving around mod_mbox. I did not get any news from the