Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Guy Ferraiolo
I'll fix that! And the stub code. WRT to gcc-4.2.3-2ubuntu7 of Sept 3, 2008, I don't have access to that environment but it looks correct to me. I'll be able to get gcc-4.2.3 but only on Mandriva. sorry, Guy On Tue, 2008-09-16 at 14:41 -0700, Justin Erenkrantz wrote: > On Tue, Sep 16, 2008

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Guy Ferraiolo
Sorry, that's called 'too much Perl'. Guy On Tue, 2008-09-16 at 16:36 -0500, William A. Rowe, Jr. wrote: > Ruediger Pluem wrote: > > > > C++ style comments are not liked by all C compilers. > > I suppose the proper answer then is > > /* //# why mess around, therefore static */ > > ? ;-) Just

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Guy Ferraiolo
I'll fix that. Guy On Tue, 2008-09-16 at 14:40 -0700, Justin Erenkrantz wrote: > On Tue, Sep 16, 2008 at 2:19 PM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > >> + //# why mess around, therefore static > > > > C++ style comments are not liked by all C compilers. > > True, but if you look at the

Re: [flood] [patch] Compilation error fix

2008-09-16 Thread Guy Ferraiolo
This looks reasonable to me but I haven't had a chance to test it myself. Guy On Wed, 2008-09-03 at 11:47 +0300, Ohad Lutzky wrote: > Hello, > > We've been using flood for a project, and couldn't get revision 672044 > to compile in gcc-4.2.3-2ubuntu7 without the attached patch. The error > we go

Re: About lingering_close

2008-09-16 Thread Greg Ames
On Sun, Sep 7, 2008 at 8:57 AM, Arnab Ganguly <[EMAIL PROTECTED]> wrote: > Hi All, > How do I enable lingering_close in Apache.Is it enabled by default in > Apache 2.2.8 ? > yes. > Is there anyway to check it. > Trace the system calls. On Linux, you can run strace against one of the worker pr

Re: svn commit: r692567 - /httpd/httpd/trunk/modules/filters/mod_charset_lite.c

2008-09-16 Thread Greg Ames
On Sat, Sep 6, 2008 at 4:38 AM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > >> +bb = apr_brigade_create(r->pool, c->bucket_alloc); >> > > This is bad. Please store the brigade in the filter context and reuse it, > by cleaning it. See also > http://httpd.apache.org/docs/trunk/en/developer/outpu

Re: svn commit: r696062 - /httpd/httpd/branches/2.2.x/STATUS

2008-09-16 Thread Justin Erenkrantz
On Tue, Sep 16, 2008 at 2:44 PM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > I think we only vote on code and not on docco. > So IMHO you could backport without votes. Ya, but since I only made the commit to trunk this morning, I figured I'd let it sit. If Jim wants to backport, he can. -- justi

Re: svn commit: r696062 - /httpd/httpd/branches/2.2.x/STATUS

2008-09-16 Thread Ruediger Pluem
On 09/16/2008 11:13 PM, [EMAIL PROTECTED] wrote: Author: jerenkrantz Date: Tue Sep 16 14:13:02 2008 New Revision: 696062 URL: http://svn.apache.org/viewvc?rev=696062&view=rev Log: * STATUS: Propose minor docco fix for backport. I think we only vote on code and not on docco. So IMHO you could

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Justin Erenkrantz
On Tue, Sep 16, 2008 at 2:36 PM, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote: > I suppose the proper answer then is > > /* //# why mess around, therefore static */ > > ? ;-) Justin, I think you could have dropped the # Hey, bub, you're the one who committed this code - not me. =) -- justin

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Justin Erenkrantz
On Tue, Sep 16, 2008 at 2:19 PM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: >> + //# why mess around, therefore static > > C++ style comments are not liked by all C compilers. True, but if you look at the hardcoded paths a few lines up, well, ya, there's a lot of work that would need to be done to

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread William A. Rowe, Jr.
Ruediger Pluem wrote: C++ style comments are not liked by all C compilers. I suppose the proper answer then is /* //# why mess around, therefore static */ ? ;-) Justin, I think you could have dropped the #

Re: svn commit: r696047 - in /httpd/flood/trunk: flood_subst_file.c flood_subst_file.h

2008-09-16 Thread Ruediger Pluem
On 09/16/2008 10:41 PM, [EMAIL PROTECTED] wrote: Author: jerenkrantz Date: Tue Sep 16 13:41:45 2008 New Revision: 696047 URL: http://svn.apache.org/viewvc?rev=696047&view=rev Log: Fix up flood_subst_file implementation so that we compile again on Mac OS X. Also fix up various nits, add licens

Re: STATUS file, 2.2.10 and voting

2008-09-16 Thread Ruediger Pluem
On 09/16/2008 09:05 PM, Justin Erenkrantz wrote: On Sun, Sep 14, 2008 at 7:02 AM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: Given the fact that Jim plans to T&R 2.2.10 mid-, late September I triaged through the STATUS file. There are 10 proposal left where 6 of them only miss one vote. From th

Re: [PATCH] Dynamic locking upcalls in mod_ssl

2008-09-16 Thread Justin Erenkrantz
On Thu, Aug 14, 2008 at 10:04 PM, Sander Temme <[EMAIL PROTECTED]> wrote: > Folks, > > The following patch against trunk adds dynamic locking callbacks to mod_ssl. > OpenSSL uses these in several places, including the CHIL engine that > interfaces with the nCipher products. I work at nCipher, and

Re: STATUS file, 2.2.10 and voting

2008-09-16 Thread Justin Erenkrantz
On Sun, Sep 14, 2008 at 7:02 AM, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > Given the fact that Jim plans to T&R 2.2.10 mid-, late September > I triaged through the STATUS file. There are 10 proposal left > where 6 of them only miss one vote. From the remaining 4 with only > one vote two are still

Re: Patch for INSTALL

2008-09-16 Thread Justin Erenkrantz
On Tue, Sep 16, 2008 at 11:41 AM, Tim Bray <[EMAIL PROTECTED]> wrote: > Just a piece of advice that, had I'd received it, would have saved me a > couple days of yak shaving. -T Doh. =) Committed in r696006. Thanks. -- justin

Re: [flood] Critical section for flood_report_relative_times.c

2008-09-16 Thread Justin Erenkrantz
On Wed, Sep 3, 2008 at 2:28 AM, Ohad Lutzky <[EMAIL PROTECTED]> wrote: > From flood_report_relative_times.c (SVN): > >/* FIXME: this call may need to be in a critical section */ > #if APR_HAS_THREADS >apr_file_printf(local_stdout, "%s %ld %s\n", buf, > apr_os_thread_current(), req->uri); >

Patch for INSTALL

2008-09-16 Thread Tim Bray
Just a piece of advice that, had I'd received it, would have saved me a couple days of yak shaving. -T === --- INSTALL (revision 695999) +++ INSTALL (working copy) @@ -37,6 +37,12 @@ include a sufficiently r

Re: [flood] [patch] Compilation error fix

2008-09-16 Thread Justin Erenkrantz
On Wed, Sep 3, 2008 at 1:47 AM, Ohad Lutzky <[EMAIL PROTECTED]> wrote: > Hello, > > We've been using flood for a project, and couldn't get revision 672044 > to compile in gcc-4.2.3-2ubuntu7 without the attached patch. The error > we got was: > > flood_round_robin.c: In function 'round_robin_profile

More accurate logging of requests per connection

2008-09-16 Thread Dan Poirier
I recently contributed a new %k log format that is intended to log how many requests have been handled on the current connection. It does this by logging the value of conn->keepalives. However, conn->keepalives isn't, strictly speaking, the number of requests the connection has handled. If k

Re: Anyone here with knowledge of MPM event?

2008-09-16 Thread Rustam Abdullaev
>> Is it possible to add some flags to the EOS metadata bucket? For example, >> to have a 'continuation' EOS bucket, which would cause the MPM to >> 'replay' the original http request after a certain time (or on demand). >> In essence there would be 2 separate requests, but they would share the